Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VCert CLI] Support for Certificate Provision and more changes #484

Merged
merged 12 commits into from
May 24, 2024
Merged

[VCert CLI] Support for Certificate Provision and more changes #484

merged 12 commits into from
May 24, 2024

Conversation

luispresuelVenafi
Copy link
Contributor

@luispresuelVenafi luispresuelVenafi commented May 22, 2024 •
edited
Loading

  • Adds support for VCert CLI provisioning which involved:
    • refactoring provisioning to allow a new keystore object in ProvisionRequest, which takes priority over any of keystoreID or both Keystore Name and Provider Name. This is to avoid running the same GetCloudKeystore API twice.
    • Thus, this also included exposing a GetCloudKeystore in cloud package for early retrieval of the keystore.
  • Added machine identity info in response after provisioning.
  • Done some fixing and removed unused code

sbanic-venafi
sbanic-venafi reviewed May 22, 2024
View reviewed changes
cmd/vcert/flags.go Outdated Show resolved Hide resolved
cmd/vcert/result_writer.go Outdated Show resolved Hide resolved
cmd/vcert/utils.go Outdated Show resolved Hide resolved
cmd/vcert/utils.go Show resolved Hide resolved
pkg/venafi/cloud/connector.go Outdated Show resolved Hide resolved
cmd/vcert/cmdCloudProviders.go Outdated Show resolved Hide resolved
cmd/vcert/utils.go Outdated Show resolved Hide resolved
pkg/venafi/cloud/connector.go Outdated Show resolved Hide resolved
pkg/webclient/cloudproviders/cloudproviders.go Outdated Show resolved Hide resolved
@luispresuelVenafi
fixes code. Adds constants for cloud types. Adds machineIdenty interf…
e9a9d5a 
…ace and logic to be retrieved for both SDK and CLI. removes GetKeystoreByName in favor of GetKeystore
@luispresuelVenafi luispresuelVenafi changed the title [VCert CLI] Support for Certificate Provision to CLoud Keystore [VCert CLI] Support for Certificate Provision and more changes May 22, 2024
rvelaVenafi
rvelaVenafi requested changes May 23, 2024
View reviewed changes
cmd/vcert/cmdCloudProviders.go Outdated Show resolved Hide resolved
cmd/vcert/main.go Outdated Show resolved Hide resolved
cmd/vcert/utils.go Show resolved Hide resolved
@luispresuelVenafi
keeps tabulation for vcp in main cli menu. moves cloudKeystore code t…
ca91c41 
…o single file. refactors flags connection validations to be more specific for provision use case and in so, avoiding make any API call before reaching provision function
rvelaVenafi
rvelaVenafi requested changes May 23, 2024
View reviewed changes
cmd/vcert/cmdCloudKeystores.go Outdated Show resolved Hide resolved
@luispresuelVenafi
Copy link
Contributor Author

@rvelaVenafi

Enforce the use of the -p flag. It is the correct way to use the CLI now.

Done by latest changes

rvelaVenafi
rvelaVenafi requested changes May 23, 2024
View reviewed changes
cmd/vcert/cmdCloudProviders.go Outdated Show resolved Hide resolved
@luispresuelVenafi luispresuelVenafi merged commit 8c021a6 into master May 24, 2024
3 checks passed
@luispresuelVenafi luispresuelVenafi deleted the VC-32826-provision-for-vcert-cli branch May 24, 2024 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbanic-venafi sbanic-venafi sbanic-venafi approved these changes

@marcos-albornoz marcos-albornoz marcos-albornoz approved these changes

@rvelaVenafi rvelaVenafi rvelaVenafi approved these changes

@JigarAtVenafi JigarAtVenafi Awaiting requested review from JigarAtVenafi

@EduardoVV EduardoVV Awaiting requested review from EduardoVV EduardoVV is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@luispresuelVenafi @rvelaVenafi @marcos-albornoz @sbanic-venafi