[VEN-2999]: add transient storage to Resilient oracle #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coreyar
force-pushed
the
feat/transient-storage
branch
from
8753f1f to
a799afb
Compare
chechu
reviewed
Dec 30, 2024
chechu
reviewed
Jan 7, 2025
web3rover
reviewed
Jan 7, 2025
contracts/ResilientOracle.sol
Outdated
| @@ -88,6 +88,9 @@ contract ResilientOracle is PausableUpgradeable, AccessControlledV8, ResilientOr | |||
|
|
|||
| mapping(address => TokenConfig) private tokenConfigs; | |||
|
|
|||
| /// Slot to cache the asset's price, used for transient storage | |||
| bytes32 constant CACHE_SLOT = keccak256(abi.encode("venus-protocol/oracle/ResilientOracle/cache")); | |||
There was a problem hiding this comment.
const vars should be declared above tokenConfigs
web3rover
reviewed
Jan 7, 2025
|
@Debugger022 The CI is failing |
chechu
changed the title
chechu
reviewed
Jan 14, 2025
contracts/ResilientOracle.sol
Outdated
Comment on lines
347
to
369
| /** | ||
| * @notice Cache the asset price into transient storage | ||
| * @param key address of the asset | ||
| * @param value asset price | ||
| */ | ||
| function _cachePrice(address key, uint256 value) internal { | ||
| bytes32 slot = keccak256(abi.encode(CACHE_SLOT, key)); | ||
| assembly ("memory-safe") { | ||
| tstore(slot, value) | ||
| } | ||
| } | ||
|
|
||
| /** | ||
| * @notice Read cached price from transient storage | ||
| * @param key address of the asset | ||
| * @return value cached asset price | ||
| */ | ||
| function _readCachedPrice(address key) internal view returns (uint256 value) { | ||
| bytes32 slot = keccak256(abi.encode(CACHE_SLOT, key)); | ||
| assembly ("memory-safe") { | ||
| value := tload(slot) | ||
| } | ||
| } |
There was a problem hiding this comment.
We could extract these functions to an external file, to reuse it in other oracles caching prices
chechu
reviewed
Jan 14, 2025
contracts/lib/Transient.sol
Outdated
Comment on lines
5
to
6
| /// Slot to cache the asset's price, used for transient storage | ||
| bytes32 public constant CACHE_SLOT = keccak256(abi.encode("venus-protocol/oracle/ResilientOracle/cache")); |
There was a problem hiding this comment.
I would not put this in the library. It seems it's specific to the ResilientOracle contract. I would allow every contract using this library to define their own slot. Wdyt?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #
Checklist