fix: fix the issue where map drag interaction cannot be terminated ou… #3658
+52
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xile611
reviewed
Jan 9, 2025
| @@ -473,7 +473,10 @@ export class Zoomable implements IZoomable { | |||
| } as unknown as BaseEventParams); | |||
| this._zoomableTrigger.pointerId = null; | |||
| this._eventObj.off(move, { level: Event_Bubble_Level.chart, source: Event_Source_Type.chart }, mousemove as any); | |||
| this._eventObj.off(end, { level: Event_Bubble_Level.chart, source: Event_Source_Type.window }, mouseup as any); | |||
| [end, `${end}outside`].forEach(type => { | |||
There was a problem hiding this comment.
@xiaoluoHe 是不是应该修改配置，将end 事件设置成 ['pointerup', 'pointerupoutside'] 更好，这里写的很死
packages/vchart/src/component/common/trigger/config.ts
xiaoluoHe
changed the title
xiaoluoHe
changed the title
xile611
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tside the canvas
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
closes #3650
🔗 Related PR link
🐞 Bugserver case id
fileid=677f863944ae5e00b2b66221&interactionid=677f86573a88ae00b2d84d55
💡 Background and solution
📝 Changelog
☑️ Self-Check before Merge
🚀 Summary
copilot:summary
🔍 Walkthrough
copilot:walkthrough