Use prettier 404 page for missing catalog pages (#2501)

* Use prettier 404 page for missing catalog pages * Enable exceptions to test for 404 Co-authored-by: Harpo <[email protected]>
WGBH-MLA · Dec 22, 2022 · 0eb9bbb · 0eb9bbb
1 parent c83437a
commit 0eb9bbb
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/app/controllers/catalog_controller.rb b/app/controllers/catalog_controller.rb
@@ -237,8 +237,8 @@ def index
   def show
     # From BlacklightGUIDFetcher
     @response, @document = fetch_from_solr(params['id'])
-    # we have to rescue from this in fetch_from_solr to run through all guid permutations, so throw it here if we didnt find anything
-    raise Blacklight::Exceptions::RecordNotFound unless @document
+    # If we didn't end up getting a @document, 404
+    raise ActionController::RoutingError.new('Not Found') unless @document
 
     xml = @document['xml']
     respond_to do |format|

diff --git a/config/environments/test.rb b/config/environments/test.rb
@@ -21,7 +21,7 @@
   config.action_controller.perform_caching = false
 
   # Raise exceptions instead of rendering exception templates.
-  config.action_dispatch.show_exceptions = false
+  config.action_dispatch.show_exceptions = true
 
   # Disable request forgery protection in test environment.
   config.action_controller.allow_forgery_protection = false