-
-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements to groups and UI #4016
Conversation
psDroid->order.type != DORDER_RTB) | ||
psDroid->order.type != DORDER_RTB && | ||
secondaryGetState(psDroid, DSO_REPAIR_LEVEL) == DSS_REPLEV_NEVER) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pastdue and I are uncertain about the purpose of this change. The intent for this if statement was to prevent a retreating unit, that was disturbed from rtr/rtb, forever having a red group number until fully repaired. Unless there is some specific behavior difference we aren't noticing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
forever having a red group number until fully repaired. Unless there is some specific behavior difference we aren't noticing.
This is only possible if there are no repair facilities or repairing units.
In the worst case, I'll just set a "do or die" flag on the units and just send them into battle, but it's too expensive to lose units. That's what alfred007 was talking about on Discord:
The point is to keep as many units as possible, at the very least let them stand at the HQ with repair group set until I build repair facilities and send them to be repaired. Currently, the damaged units will just go into battle with low health which is worse.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is also an idea to make damaged units that stand at the HQ, automatically go to repair when at least one repair facility appears (I can do this, but it would be in a separate PR).
Summary of this PR: