Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: automatically use X-Forwarded-For from built-in nginx #2897

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

nijel
Copy link
Member

@nijel nijel commented Dec 19, 2024

Proposed changes

In the SSL setup the X-Forwarded-For header is created by the built-in nginx server so Weblate should use it unless configured otherwise.

See WeblateOrg/weblate#13325

Checklist

  • Lint and unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added documentation to describe my feature.
  • I have squashed my commits into logic units.
  • I have described the changes in the commit messages.

Other information

In the SSL setup the X-Forwarded-For header is created by the built-in
nginx server so Weblate should use it unless configured otherwise.

See WeblateOrg/weblate#13325
@nijel nijel self-assigned this Dec 19, 2024
@nijel nijel enabled auto-merge (rebase) December 19, 2024 09:05
@nijel nijel merged commit 4bdd608 into WeblateOrg:main Dec 19, 2024
42 checks passed
@nijel nijel deleted the proxy-ssl branch December 19, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant