Faster episode booting #70
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 18 commits
January 19, 2024 23:47
…boot, to make sure that there's a check before doing things for Misc.loadEpisode
Emral
reviewed
Jan 22, 2024
Emral
reviewed
Jan 22, 2024
added 10 commits
January 21, 2024 21:27
…for LunaLua (World only)
…d from an episode (Make playerStoredCharacters global), and have a shortened LaunchEpisode for Misc.loadEpisode
…from Misc.loadEpisode to LanuchEpisode itself
added 29 commits
January 25, 2024 09:40
…not loading the proper wld file when specifying a name
…erly/LunaLua into faster-episode-booting
…and other player IDs of a higher player count specified
…he first/second characters that may not apply them correctly
… to warn you: Some episodes might crash.
…o attempt to make external episode booting better but it's not there yet
…mit I'll merge the latest LunaLua commit)
…below the file to prevent commit merge breaking changes
- On the fast episode boot source codes & GlobalFunc.cpp fast episode boot source codes: Switch old GM, old native functions, and old SMBXInternal things to the new SMBX13 namespace environment
- Port "Misc.getEpisodeList" to a new LuaBind namespace ("Episode"), along with adding some new world-related functions, as well as renaming the functions to be shorter and easier to remember ("Misc.getEpisodeList()" is now "Episode.list()", and there's also "Episode.id()", "Episode.name()", "Episode.path()", and "Episode.filename()")
- Replace "WStr2Str(gAppPathWCHAR)" with gAppPathUTF8 in the checkIfWorldIsIn* functions (It looks better this way)
- Make episode loading more better, it hopefully can now withstand more than 100 episodes in the worlds folder (Though it's still capped at 100)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another pull request by me. I decided to make a new way of booting episodes on boot, so rather than use the old method of "booting intro.lvl -> select episode from list -> boot it -> load episode", I decided on bypassing intro.lvl ENTIRELY so now that it's "skip intro.lvl -> load episode".
Check out this video for a loading comparison for Super Mario Bros. 2024, an episode by vitzie629: https://youtu.be/IDYBZzBwuzI
Note: When loading LunaLoader.exe by itself with this PR, it tells you to use the SMBX2 launcher instead to load LunaLoader.exe. This means the final way to use the old legacy launcher is finally bypassed, and any way to use intro.lvl is no longer possible.