-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update theme form markup and styles #470
Update theme form markup and styles #470
Conversation
They look like good changes, though I only did a cursory glance. To be honest I would rather just completely remove the The only parts of the workflow that I know aren't available in the site editor are:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm keen on getting this in, regardless of what we decide on for the future of the admin page; these changes are a valuable improvement for it in the meantime.
Thanks for the reviews and feedback! To me it seems worth merging this, even if we end up throwing it out soon in favor of other changes to the wp-admin section of the plugin. Note that I added a couple more small tweaks based on feedback from running the form markup through validator.w3.org. This seems ready to go, so I'll go ahead and merge it! |
For anyone following here, I made a mistake in my final markup changes that removed a closing |
This change adds a handful of improvements to the markup and styles for the main plugin page, including
aria-describedby
attributeTesting instructions
/wp-admin/themes.php?page=create-block-theme
and make sure the form submits successfully