-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove/font management & wp-admin forms #528
Conversation
I think we should get all of the options on the wp-admin form into the site editor before removing the form. It doesn't look like creating a theme variation or child theme is possible in the site editor right now. I recall seeing the child theme option used in the theme builder conversations from last year. |
Yes, both of those features need to be in the site editor before we release. I'll get both of those features added to the list; they should both be pretty easy to add. I don't think we need to wait to remove this code though; the admin will need to be gone before v2 ships and the features need to be in before v2 ships. |
0ba91ed
to
9a6cf19
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm don't think we should remove the current admin page without first creating the replacement. Am I missing something in terms of the benefit of doing this ahead of starting that work?
9a6cf19
to
e360fec
Compare
Closing this. Half of it is already in with #595 and the rest should just be done again when a replacement exists. |
This change removes all of the wp-admin forms for Create Block Theme including font management and theme management.
The Sidebar tools should continue to build and work as expected.
A new "admin-landing" app has been stubbed out to replace it.