Block Editor: Fix color contrast checker #67036
Open
+67
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanfra
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +142 B (+0.01%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in f13b8dd. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12502161305
|
Mamaduka
force-pushed
the
try/67035-contrast-checker
branch
from
58daf01 to
e5cc26e
Compare
|
Thanks for working on this, @juanfra! I pushed some minor changes, such as fixing the ESLint error and stylistic updates. The
|
Mamaduka
changed the title
Mamaduka
force-pushed
the
try/67035-contrast-checker
branch
from
f13b8dd to
d3ed087
Compare
|
Thanks for the review and for pushing those changes, @Mamaduka! I appreciate it. I’m slowly easing back into things after the holiday break. I’ll take another look at this next week. I'm still hesitant this is the right approach, because originally the useEffect should be taking care of things, with the right dependencies. However, the values retrieved there are holding onto the previous state, so something isn’t quite right. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #67035
Adding an observer to the contrast checker with the objective of checking the styles changes in real-time, so that we show the correct messaging.
Why?
Right now, the contrast checker only runs when you change the block focus. This means if you’re adjusting colors for a block, the contrast issue message only appears after you switch to another element and then come back to the block controls. As a result, many users might miss the contrast warning entirely, defeating its purpose.
How?
Adding the observer, so the check runs when there are style changes for the block.
Testing Instructions
Screenshots or screencast
Screen.Recording.2024-11-15.at.15.28.02.mov