Button: Update hover styles to account for pressed state for tertiary button

[yogeshbhutkar]

What, Why and How?

As noted in the comment, the is-pressed CSS rule was overridden on hover, resulting in a dark blue accent that reduced readability.

gutenberg/packages/components/src/button/style.scss

Line 172 in ef7afef

color: $components-color-accent-darker-20;

This PR introduces an additional :not condition to ensure the color property is applied only when the is-pressed state is not active.

Testing Instructions

1. Start storybook using npm run storybook:dev command.
2. Navigate to Button component.
3. Make sure the variant is tertiary.
4. Notice, the text color stays white on hover.

Screencasts

Before	After

The settings button hover effect

It was found to work as expected.

Closes: #68535

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: yogeshbhutkar <[email protected]>
Co-authored-by: afercia <[email protected]>
Co-authored-by: patil-vipul <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[afercia]

I'd suggest to wait for some feedback from @WordPress/gutenberg-design and see what is the desired styling.
Edge case: I think the :active non-hovered state makes the background color turn to a light gray? To test:

• Go to https://wordpress.github.io/gutenberg/?path=/story/components-button--tertiary&args=aria-pressed:true
• Click the button and hold your mouse/trackpad pressed down.
• Move the cursor away from the button.
• Observe the button background turns to a light gray.

Screenshot:

[yogeshbhutkar]

Thanks for the review, @afercia. I think I've considered the :active state already and have fixed the bug by explicitly setting the color when the button is active. However, I've noticed a similar issue with the secondary variant of the button.

I'll await design feedback on this one, post which, I should have a clear path forward.