Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add uniform image sizes toggle to Gallery Block #68585

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from

Conversation

yogeshbhutkar
Copy link
Contributor

What, Why & How?

Adds support for maintaining uniform image sizes in gallery blocks, preventing the last image in a row from expanding to full width when there are fewer images than columns.

  • Added new has-uniform-image-sizes class support.
  • Used flex properties to maintain consistent image widths.
  • Prevented image growth using flex: 0 0 width.
  • Maintained existing gap calculations.
  • Preserved default column behavior when uniform sizing is disabled.

Testing Instructions

  1. Create a Gallery Block.
  2. Add 4 Image Blocks to it.
  3. Set the column count to 3.
  4. Notice, by default the last image occupies the full width.
  5. Try toggling the control labeled uniform image sizes and notice all the image blocks now take the same sizes.

Screencast

Feature Demo

Closes: #68563

@yogeshbhutkar yogeshbhutkar marked this pull request as ready for review January 10, 2025 09:22
Copy link

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core, Gutenberg Plugin.
  • Labels found: .

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: yogeshbhutkar <[email protected]>
Co-authored-by: jartes <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@yogeshbhutkar
Copy link
Contributor Author

The feature implementation is complete. I will update the test cases after the initial round of review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gallery Block: Add option to keep images the same size
1 participant