Components: Fix icon condition for Badge #68588
Conversation
Mamaduka
added
[Type] Bug
Mamaduka
force-pushed
the
fix/component-badge-intent-icon
branch
from
d99868d to
7922597
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Flaky tests detected in 7922597. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12706234639
|
| className | ||
| ) } | ||
| className={ clsx( 'components-badge', className, { | ||
| [ `is-${ intent }` ]: intent, |
There was a problem hiding this comment.
Should we also apply the is-intent classname only if hasIcon ?
There was a problem hiding this comment.
Not a big difference. IMO, this method is more future-proof and will avoid is-undefined if we ever remove the default for the intent prop.
|
Thanks, Marco. I'm going to skip the changelog entry since this is a private component. |
What?
PR fixes a condition when a Badge might render an icon; now, it depends on the value returned by the
contextBasedIconhelper.Why?
While TypeScript will inform consumers that they're passing an invalid value as
intent, components can also be accessed viawp.component, which allows users to pass unsupported intents like -alert.Testing Instructions
npm run storybook:dev.Testing Instructions for Keyboard
Same
Screenshots or screencast