Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the bug for level set generation in debug mode #624

Merged
merged 1 commit into from
Jul 16, 2024
Merged

Fix the bug for level set generation in debug mode #624

merged 1 commit into from
Jul 16, 2024

Conversation

Xiangyu-Hu
Copy link
Owner

@FengWang3119 @ChenxiZhaoTUM Please have look if this bug fix solve your problem on level set generation.

@Xiangyu-Hu Xiangyu-Hu changed the title Fiy the bug for level set generation in debug mode Fix the bug for level set generation in debug mode Jul 15, 2024
@Xiangyu-Hu Xiangyu-Hu linked an issue Jul 15, 2024 that may be closed by this pull request
For very long channel, level-set intialisation enters infinite loop #615
Open
@FengWang3119
Copy link
Collaborator

Still not working for my case.
It is strange, for DL=120 DL=60 it is OK for water_block.defineBodyLevelSetShape(), but for DL=100 it is keeping looping.
QQ_1721067700460
Is is because we use the EXTRUDE?

@Xiangyu-Hu
Copy link
Owner Author

Still not working for my case. It is strange, for DL=120 DL=60 it is OK for water_block.defineBodyLevelSetShape(), but for DL=100 it is keeping looping. QQ_1721067700460 Is is because we use the EXTRUDE?

I guess only a close look can find the reason.

@Xiangyu-Hu
Copy link
Owner Author

Or it is a different issue?

@Xiangyu-Hu
Copy link
Owner Author

Anyway, I found the previous bug on debug mode solved.

@Xiangyu-Hu Xiangyu-Hu requested a review from Lisu-lisa July 15, 2024 20:06
@Xiangyu-Hu Xiangyu-Hu removed a link to an issue Jul 16, 2024
For very long channel, level-set intialisation enters infinite loop #615
Open
@Lisu-lisa Lisu-lisa merged commit 24dbebf into master Jul 16, 2024
7 checks passed
@Lisu-lisa Lisu-lisa deleted the debug/fan branch July 16, 2024 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lisu-lisa Lisu-lisa Lisu-lisa approved these changes

@FengWang3119 FengWang3119 Awaiting requested review from FengWang3119

@ChenxiZhaoTUM ChenxiZhaoTUM Awaiting requested review from ChenxiZhaoTUM

Assignees

@FengWang3119 FengWang3119

@ChenxiZhaoTUM ChenxiZhaoTUM

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Xiangyu-Hu @FengWang3119 @Lisu-lisa @ChenxiZhaoTUM @Franguuuu