-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
diffusion dynamics in SYCL #719
Open
Xiangyu-Hu
wants to merge
26
commits into
master
Choose a base branch
from
xinagyu/discrete_constant
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By introducing variable array and constant array, now the diffusion dynamics can be run on GPU.
The follows are summary generated by copilot:
This pull request includes several changes to improve the codebase by adding new templates and classes, refactoring existing structures, and updating documentation. The most important changes include the addition of new templates for handling pairs and return types, refactoring of constant and variable array classes, and updates to reduce functors and dynamics sequences.
New Templates and Classes:
src/shared/common/base_data_type.h
: AddedZeroData
specialization forstd::pair
to handle pairs of types.src/shared/common/common_functors.h
: AddedReturnFunction
template to define a return type for various functors.src/shared/particle_dynamics/base_local_dynamics.h
: AddedFinalOutput
class withinBaseLocalDynamicsReduce
to handle final output of reduction operations.Refactoring of Constant and Variable Arrays:
src/shared/common/sphinxsys_constant.h
: RefactoredDiscreteConstant
and related classes intoConstantArray
andDeviceOnlyConstantArray
to handle arrays of constants more efficiently.src/shared/common/sphinxsys_variable_array.h
: RefactoredVariableArray
and related classes to simplify handling of variable arrays, including addingDeviceOnlyVariableArray
. [1] [2]Updates to Reduce Functors:
src/shared/particle_dynamics/reduce_functors.h
: Refactored reduce functors to useReturnFunction
and added specializations for handling pairs inReduceSum
. [1] [2] [3] [4] [5] [6] [7]Updates to Dynamics Sequences:
src/shared/shared_ck/particle_dynamics/complex_algorithms_ck.h
: RefactoredSequencedCombination
toDynamicsSequence
to streamline the execution of dynamics sequences.Documentation and Miscellaneous Updates:
README.md
: Removed outdated information about master and stable branches.src/shared/io_system/io_plt.cpp
: Minor formatting changes to improve readability.src/shared/shared_ck/io_system/io_observation_ck.h
: UpdatedReducedQuantityRecording
to useFinalOutput
for deducing variable type. [1] [2]src/shared/shared_ck/particle_dynamics/all_shared_physical_dynamics_ck.h
: Includeddiffusion_dynamics_ck.hpp
header.