Now the aligned box becomes device copyable now. #720
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All virtual functions all deleted so that it can be copyable to device.
Here is the summary given by copilot:
This pull request includes several changes aimed at refactoring and renaming classes and files for better clarity and consistency in the codebase. The most significant changes involve renaming
complex_shape
tocomplex_geometry
, updating theGeometricShapeBox
class, and introducing a newGeometricBox
class.Refactoring and Renaming:
complex_shape
tocomplex_geometry
across multiple files to improve clarity and consistency. (src/for_2D_build/geometries/all_geometries.h
[1]src/for_3D_build/geometries/all_geometries.h
[2]src/shared/geometries/complex_geometry.cpp
[3]src/shared/geometries/complex_geometry.h
[4]src/shared/geometries/complex_geometry.h
[5]src/shared/geometries/complex_geometry.h
[6]src/shared/geometries/transform_geometry.h
[7]Class Updates:
GeometricShapeBox
to inherit fromGeometricBox
andShape
, and refactored related methods to useGeometricBox
methods. (src/for_2D_build/geometries/geometric_shape.cpp
[1]src/for_2D_build/geometries/geometric_shape.cpp
[2]src/for_2D_build/geometries/geometric_shape.h
[3]New Class Introduction:
GeometricBox
class to encapsulate the geometric box functionalities, including methods for checking containment and finding the closest point. (src/shared/geometries/geometric_element.cpp
[1]src/shared/geometries/geometric_element.h
[2]Body Part Classes:
BodyAlignedBoxByParticle
andBodyAlignedBoxByCell
classes to handle particle and cell tagging within an aligned box. (src/shared/bodies/base_body_part.cpp
[1]src/shared/bodies/base_body_part.h
[2]These changes collectively aim to improve the readability, maintainability, and functionality of the codebase.