Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Now the aligned box becomes device copyable now. #720

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Xiangyu-Hu
Copy link
Owner

All virtual functions all deleted so that it can be copyable to device.

Here is the summary given by copilot:

This pull request includes several changes aimed at refactoring and renaming classes and files for better clarity and consistency in the codebase. The most significant changes involve renaming complex_shape to complex_geometry, updating the GeometricShapeBox class, and introducing a new GeometricBox class.

Refactoring and Renaming:

  • Renamed complex_shape to complex_geometry across multiple files to improve clarity and consistency. (src/for_2D_build/geometries/all_geometries.h [1] src/for_3D_build/geometries/all_geometries.h [2] src/shared/geometries/complex_geometry.cpp [3] src/shared/geometries/complex_geometry.h [4] src/shared/geometries/complex_geometry.h [5] src/shared/geometries/complex_geometry.h [6] src/shared/geometries/transform_geometry.h [7]

Class Updates:

  • Updated GeometricShapeBox to inherit from GeometricBox and Shape, and refactored related methods to use GeometricBox methods. (src/for_2D_build/geometries/geometric_shape.cpp [1] src/for_2D_build/geometries/geometric_shape.cpp [2] src/for_2D_build/geometries/geometric_shape.h [3]

New Class Introduction:

  • Added a new GeometricBox class to encapsulate the geometric box functionalities, including methods for checking containment and finding the closest point. (src/shared/geometries/geometric_element.cpp [1] src/shared/geometries/geometric_element.h [2]

Body Part Classes:

  • Introduced BodyAlignedBoxByParticle and BodyAlignedBoxByCell classes to handle particle and cell tagging within an aligned box. (src/shared/bodies/base_body_part.cpp [1] src/shared/bodies/base_body_part.h [2]

These changes collectively aim to improve the readability, maintainability, and functionality of the codebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant