Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: add python 3.13 support #900

Merged
merged 10 commits into from
Jan 6, 2025

Conversation

clintonsteiner
Copy link
Contributor

  • Please check if the PR fulfills these requirements
  • [ X] Tests for the changes have been added
  • [X ] Docs have been added / updated
  • [ X] All CI checks are green
  • What kind of change does this PR introduce?
  • What is the current behavior?
  • What is the new behavior (if this is a feature change)?

  • Does this PR introduce a breaking change?

  • Other information:

Copy link
Member

@jpdakran jpdakran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Can you update the tox.ini as well with py3.13

@clintonsteiner
Copy link
Contributor Author

Looks good to me. Can you update the tox.ini as well with py3.13

Done. Thanks for the review!

@clintonsteiner
Copy link
Contributor Author

Foce pushed to retrigger run of cicd

@clintonsteiner
Copy link
Contributor Author

@jpdakran Think this is good for merge
Would you be able to rereview

.pre-commit-config.yaml Outdated Show resolved Hide resolved
@clintonsteiner
Copy link
Contributor Author

@jpdakran should I update the CHANGELOG as well? Looks like that is stale now

@jpdakran
Copy link
Member

jpdakran commented Jan 6, 2025

@clintonsteiner We'll get that updated on next release 👍

@clintonsteiner
Copy link
Contributor Author

@jpdakran in that case just need you to validate requested change is fixed and merge this in
Would you like a squash?

@jpdakran jpdakran merged commit 50119d6 into Yelp:master Jan 6, 2025
15 checks passed
@clintonsteiner clintonsteiner deleted the addPython3.13Support branch January 6, 2025 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants