Lucene 9.8 #624
Merged
Lucene 9.8 #624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrading to Lucene 9.8. Changes:
leafCollector.finish()inMyIndexSearcherlike it's added toIndexSearcherin Add a post-collection hook to LeafCollector. apache/lucene#12380. Without this, facet tests were failing since the data structures for adding matching docs were not getting updated. We should also look into removing the overriden search method in MyIndexSearcher - I'm not sure if it's needed now.KnnCollectortoNrtsearchKnnCollectorbecause Lucene 9.8 adds an interface calledKnnCollector: Add ParentJoin KNN support apache/lucene#12434. We should probably look into implementing this.Example plugin test fails because the jar is not uploaded yet.