Add zeroTermsQuery for matchPhraseQuery #648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aprudhomme
reviewed
Apr 16, 2024
| @@ -190,6 +190,7 @@ message MatchPhraseQuery { | |||
| string query = 2; // The text to query with. | |||
| int32 slop = 3; // Edit distance between respective positions of tokens generated by analyzing this query and the positions of terms in a document. | |||
| Analyzer analyzer = 4; // Analyzer used to analyze the query. If not provided, the default search analyzer for the field would be used instead. | |||
| string zeroTermsQuery = 5; // Optional field. Indicates whether none or all documents are returned if the analyzer removes all tokens. Valid values are "none" and "all". | |||
There was a problem hiding this comment.
If this only has two possible values, could it be an enum?
aprudhomme
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support returning all or no docs if the analyzer removes all tokens in a match query.
Requirements