Use direct executor for DrillSideways tasks #651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarthakn7
reviewed
Apr 22, 2024
| @@ -148,7 +147,7 @@ public SearchResponse handle(IndexState indexState, SearchRequest searchRequest) | |||
| shardState, | |||
| searchContext.getQueryFields(), | |||
| grpcFacetResults, | |||
| threadPoolExecutor, | |||
| DIRECT_EXECUTOR, | |||
There was a problem hiding this comment.
Can we add some comments here so that it's clear why we are using the direct executor?
sarthakn7
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DrillSidewaystakes anExecutorService, which it used to enqueue drill down sub tasks during search. We are currently passing the search thread pool.Since both
DrillSidewaysand parallel search use the same thread pool, there is an execution dependency that can lead to deadlock. This can happen when a burst of requests fill the search thread pool will justDrillSidewaystask, preventing spawned search tasks from running.This branch uses a direct executor to run the
DrillSidewaystasks in the calling thread (grpc thread). Since we never add any additional drill downs to the query, there will be only oneDrillSidewaystask.