Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable preload if default FSDirectory is resolved as MMapDirectory #814

Closed
wants to merge 1 commit into from
Closed

enable preload if default FSDirectory is resolved as MMapDirectory #814

wants to merge 1 commit into from

Conversation

waziqi89
Copy link
Contributor

rp-12459

Allow preload if using default FSDirectory and it returns MMapDirectory. This is a backport of V1 (https://github.com/Yelp/nrtsearch/blob/main/src/main/java/com/yelp/nrtsearch/server/index/DirectoryFactory.java#L64)

@waziqi89 waziqi89 requested a review from sarthakn7 January 15, 2025 19:41
@waziqi89 waziqi89 marked this pull request as ready for review January 15, 2025 19:41
sarthakn7
sarthakn7 reviewed Jan 15, 2025
View reviewed changes
Copy link
Contributor

@sarthakn7 sarthakn7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please send the PR to main branch first and then backport to v0.x if needed

@sarthakn7
Copy link
Contributor

sarthakn7 commented Jan 15, 2025 •
edited
Loading

Please send the PR to main branch first and then backport to v0.x if needed

Nvm I think this is already there in v1, I didn't read the complete description

sarthakn7
sarthakn7 reviewed Jan 15, 2025
View reviewed changes
Copy link
Contributor

@sarthakn7 sarthakn7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you done any testing locally to verify if this improves the bootstrap time?

@waziqi89
Copy link
Contributor Author

Have you done any testing locally to verify if this improves the bootstrap time?

My initial plan was to test in prod canaries, but yes, I can test in local first

@waziqi89 waziqi89 closed this Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarthakn7 sarthakn7 sarthakn7 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@waziqi89 @sarthakn7