Respect a service's docker_registry for adhoc spark-runs #3728
+16
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are some services where we want to ensure that a specialized docker registry is always used - even for adhoc development runs. This change is loosely based on what we do in push-to-registry, where we read service.yaml to see if a specialized registry needs to be used.
nemacysts
requested review from
jfongatyelp,
y-trobinso,
nanflasted,
danielpops,
88manpreet,
CaptainSame,
chelspea and
EvanKrall
nemacysts
commented
Oct 23, 2023
Comment on lines
+1071
to
+1074
| registry_uri = args.docker_registry or _get_adhoc_docker_registry( | ||
| service=args.service, | ||
| soa_dir=args.yelpsoa_config_root, | ||
| ) |
There was a problem hiding this comment.
the intent here is to allow --docker-registry to override whatever is in yelpsoa
|
(I tested this locally with the -y flag and verified that by default docker-dev is still used) |
|
(and that --docker-registry takes precedence over service.yaml) |
y-trobinso
approved these changes
Oct 23, 2023
jfongatyelp
approved these changes
Oct 23, 2023
88manpreet
approved these changes
Oct 23, 2023
cuza
added a commit
that referenced
this pull request
Oct 25, 2023
…nd-ckj-aware-of-downthenup-bounces-across-namespaces * origin/master: Update paasta_tools/kubernetes_tools.py Released 0.205.1 via make release Use the correct registry_uri to check if we need to sudo Released 0.205.0 via make release Respect a service's docker_registry for adhoc spark-runs (#3728) Update requirements-dev-minimal.txt Making paasta playground not override existing confs add VSCode debugpy as dev requirement added paasta-crons make target Adding LimitRanges for paasta managed namespaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some services where we want to ensure that a specialized docker registry is always used - even for adhoc development runs.
This change is loosely based on what we do in push-to-registry, where we read service.yaml to see if a specialized registry needs to be used.