RFC: Add additional custom namespaces to k8s schema #3731
Closed
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I see two potential solutions for allowing folks to use arbitrary namespaces: * we gatekeep them by needing us to add their namespace to this allowlist (which lets us make sure that they've correctly labeled their namespace as well as done everything else that we expect) OR, * we get rid of the allowlist and allow folks to put whatever namespace they'd like and expect that they know what they're doing :)
EmanElsaban
approved these changes
Oct 26, 2023
|
I think for now option 1 seems good because it's an exception but if we saw later more cases that require other ns then maybe we allow whatever ns? |
|
I would personally prefer the second option (getting rid of the allowlist) since it's less effort, but I'm not sure what everyone else thinks :) |
EmanElsaban
approved these changes
Oct 26, 2023
|
we'll go with #3732 instead :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I see two potential solutions for allowing folks to use arbitrary namespaces: