Only drop capabilities that are not added #3972
Merged
+11
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It appears that containerd (or k8s 1.24?) have changed the behavior around adding/dropping linux capabilities and added caps no longer take precedence over dropped ones
wilmer05
previously approved these changes
Sep 25, 2024
ajayOO8
previously approved these changes
Sep 25, 2024
ajayOO8
previously approved these changes
Sep 25, 2024
wilmer05
previously approved these changes
Sep 25, 2024
ajayOO8
approved these changes
Sep 25, 2024
wilmer05
approved these changes
Sep 25, 2024
nemacysts
added a commit
to Yelp/task_processing
that referenced
this pull request
Dec 19, 2024
Just like Yelp/paasta#3972 and Yelp/paasta#3973, we need to ensure that there are no duplicates between cap_add and cap_drop - otherwise, the cap_drop entry will "win" and the duplicate capability will not be added.
nemacysts
added a commit
to Yelp/task_processing
that referenced
this pull request
Jan 9, 2025
Just like Yelp/paasta#3972 and Yelp/paasta#3973, we need to ensure that there are no duplicates between cap_add and cap_drop - otherwise, the cap_drop entry will "win" and the duplicate capability will not be added.
nemacysts
added a commit
to Yelp/Tron
that referenced
this pull request
Jan 9, 2025
Just like Yelp/paasta#3972 and Yelp/paasta#3973, we need to ensure that there are no duplicates between cap_add and cap_drop - otherwise, the cap_drop entry will "win" and the duplicate capability will not be added.
nemacysts
added a commit
to Yelp/Tron
that referenced
this pull request
Jan 9, 2025
Just like Yelp/paasta#3972 and Yelp/paasta#3973, we need to ensure that there are no duplicates between cap_add and cap_drop - otherwise, the cap_drop entry will "win" and the duplicate capability will not be added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that containerd (or k8s 1.24?) have changed the behavior around adding/dropping linux capabilities and added caps no longer take precedence over dropped ones