Add 'decoder' Parameter to VideoFileClip and ffmpeg_reader #2229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FFmpeg's native VPx decoders don't decode alpha. You have to use the libvpx decoder to preserve transparency in .webm video.
This commit allows the user to specify the the decoder used to decode the video file.
Example of use:
VideoFileClip("video.webm", decoder="libvpx-vp9")
|
To preserve the alpha channel also needs to set has_mask parameter to True: VideoFileClip("video.webm", has_mask=True, decoder="libvpx-vp9") |
|
The original problem was fixed by #2269, do you think we still need to add a codec parameter in regard to this new information, or should we let ffmpeg choose by himself ? |
|
Actually #2230 answer that question, I close |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit allows users to specify the decoder used to decode the video file.
Fixed bug:
Solved issue:
References:
"FFmpeg's native VPx decoders don't decode alpha. You have to use the libvpx decoder to preserve transparency in .webm videos. "
Example of use:
VideoFileClip("video.webm", decoder="libvpx-vp9")