Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Structure folder for platforms #764

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Structure folder for platforms #764

merged 1 commit into from
Nov 15, 2024

Conversation

tobiolo
Copy link
Collaborator

@tobiolo tobiolo commented Nov 15, 2024

No description provided.

@tobiolo tobiolo force-pushed the platforms branch 6 times, most recently from 6a8e669 to c61e8f9 Compare November 15, 2024 08:27
@tobiolo tobiolo requested a review from aardappel November 15, 2024 09:12
@aardappel
Copy link
Owner

can you rebase?

@tobiolo
Copy link
Collaborator Author

tobiolo commented Nov 15, 2024

can you rebase?

Yes, I did.

@aardappel
Copy link
Owner

I don't see the advantage of putting a platforms dir in between, this creates hierarchy where none is needed, given that we have so few dirs anyway. You can instead improve the existing code structure by just renaming the treesheets dir to win64 or better just win since linux and osx don't specify their bit-width either :) We don't have win32 builds anymore.

@tobiolo tobiolo force-pushed the platforms branch 3 times, most recently from ee28fc9 to f572d45 Compare November 15, 2024 18:44
@tobiolo
Copy link
Collaborator Author

tobiolo commented Nov 15, 2024

I don't see the advantage of putting a platforms dir in between, this creates hierarchy where none is needed, given that we have so few dirs anyway. You can instead improve the existing code structure by just renaming the treesheets dir to win64 or better just win since linux and osx don't specify their bit-width either :) We don't have win32 builds anymore.

Ok, I applied your proposal. Does it look good?

@aardappel
Copy link
Owner

yup looks good!

@aardappel aardappel merged commit ed8d1ed into aardappel:master Nov 15, 2024
4 checks passed
@tobiolo tobiolo deleted the platforms branch November 15, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aardappel aardappel Awaiting requested review from aardappel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tobiolo @aardappel