Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Dockerfile #1343

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
FROM python:3.10.14-slim-bullseye

LABEL software="spades" \
author="Sebastian Bassi <[email protected]>" \
base_image="python:3.10.14-slim-bullseye" \
container="spades" \
about.summary="genome assembler for single-cell and isolates data sets" \
about.home="https://ablab.github.io/spades/" \
software.version="4.0.0" \
upstream.version="4.0.0" \
version="1" \
extra.identifiers.biotools="spades" \
about.copyright="2011-2014 Saint-Petersburg Academic University" \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not accurate.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check again, just made changes to address these issues

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would probably suggest you to build in the same way as release snapshots are being built: https://github.com/ablab/spades/blob/main/.github/workflows/release.yml#L53

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just tried this method, got the binaries but the spades.py test does not end in bin directory.

Here is what I tried:

cmake -B build/ -S src/ -DSPADES_USE_NCBISDK=ON -DSPADES_ENABLE_PROJECTS=all
cmake --build build/ -j16

after this, binaries are in bin, but not spades.py

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'd also need to to cmake --install. Alternatively, just pass -DSPADES_USE_NCBISDK=ON -DSPADES_ENABLE_PROJECTS=all to spades_compile.sh.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will try it tomorrow

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done, updated the Dockerfile and tested it

about.license="GPL-2+" \
about.license_file="/usr/share/doc/spades/copyright" \
extra.binaries="/usr/bin/metaspades,/usr/bin/metaspades.py,/usr/bin/plasmidspades,/usr/bin/plasmidspades.py,/usr/bin/rnaspades,/usr/bin/rnaspades.py,/usr/bin/spades,/usr/bin/spades.py,/usr/bin/truspades,/usr/bin/truspades.py" \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not think this is for 4.0.0:

  • There is no truspades anymore
  • There are more binaries there

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was based in an older Dockerfile published by Biocontainers, will remove old lines

about.tags="biology::nucleic-acids, field::biology, field::biology:bioinformatics,:c++,:python, interface::commandline,:program, scope::utility, works-with::biological-sequence,:file"

USER root

RUN apt-get update && apt-get install -y build-essential cmake wget libbz2-dev

RUN wget https://github.com/ablab/spades/releases/download/v4.0.0/SPAdes-4.0.0.tar.gz

RUN tar xfz SPAdes-4.0.0.tar.gz && rm SPAdes-4.0.0.tar.gz && cd SPAdes-4.0.0/ && ./spades_compile.sh

# ./SPAdes-4.0.0/bin/spades.py --test