Small improvements to lispy-eval
#682
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We prioritize using eros if available, but we make sure not to use it if we're in a clojure mode and cider is installed. This fixed an issue where lisp modes that didn't use cider weren't able to display evaluation results with an overlay because lispy was passing a string argumet to cider--display-interactive-eval-result, which now requires a symbol.
Since eros (at least at a9a92bdc6be0521a6a06eb464be55ed61946639c) uses `format` to display the object we pass, we won't have a correct result unless we use `read` here.
|
Ah, someone's already made a PR for the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, thanks for the great package!
I've been using
lispyfor a long time, but when I recently switch over to doom emacs, I noticedlispy-evalwasn't working as I expected in theoverlaymode. It was defaulting to usingciderwhen it should've been usingeros(for Common Lisp and emacs lisp). Also, the formatting included extra quotes. This PR fixes these issues.I haven't checked the changes with clojure yet, but I suspect there's something broken there as well (cider is now insisting on a symbol argument for
cider--display-interactive-eval-result).