-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ingested CL 2024 Volume 4 #4296
Conversation
Build successful. Some useful links:
This preview will be removed when the branch is merged. |
Thanks, @davidstap. I have a request, if you have time: can you migrate the ingestion script to use the
|
I looked at the documentation and example, but I'm having some difficulties migrating the script.
|
@davidstap Thanks for starting to look into this! My hope with the new library is that manual construction of XML will be entirely unnecessary, but I haven't prioritized the necessary functionality for this yet. It’s mostly there, but not really finalized or tested. I can start with this particular ingestion script though to see what changes would be needed. |
Thanks @mbollmann that'd be great. Let me know if I can help. |
Had a quick look now, and I would move the adaption of the ingestion script into a new issue/PR, as I don’t think it is that trivial. Currently, it’s fundamentally built around constructing XML nodes manually, which is not really something I’d like to support with the new library, as it defeats the whole point of encapsulating serialization logic within a library in the first place. The new library is designed from the ground up to have its classes closely mirror what’s in our data files, to make converting from/to XML easy, so I believe we should make proper use of that. I need to implement a couple more things for that to work smoothly, though. @davidstap Can you send me the source file from MIT press that you used for this ingestion, so that I can test-run the script locally? |
Thanks @mbollmann, that makes sense and explains why it's not straightforward to make the adaption of the ingestion script. I've just shared the MIT press source file through e-mail. @mjpost can you review the CL ingestion? |
No description provided.