Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge v0.5.1 release, changes package name to acl-anthology #4305

Merged
merged 11 commits into from
Jan 3, 2025

Conversation

mbollmann
Copy link
Member

This closes #4300

Also fixes the ReadTheDocs documentation, which hasn't been built anymore after changing repos.

@mbollmann mbollmann requested a review from mjpost January 2, 2025 20:49
Copy link

codecov bot commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.56%. Comparing base (75a6a5b) to head (dfda10f).
Report is 14 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4305   +/-   ##
=======================================
  Coverage   92.55%   92.56%           
=======================================
  Files          32       32           
  Lines        2298     2301    +3     
=======================================
+ Hits         2127     2130    +3     
  Misses        171      171           
Files with missing lines Coverage Δ
python/acl_anthology/config.py 100.00% <100.00%> (ø)
python/acl_anthology/exceptions.py 96.00% <ø> (ø)
python/acl_anthology/venues.py 85.50% <100.00%> (+0.65%) ⬆️

Copy link
Member

@mjpost mjpost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Via grep -r, you missed one instance in bin/anthology/__init__.py.

@mbollmann mbollmann merged commit e31ad50 into master Jan 3, 2025
12 checks passed
@mbollmann
Copy link
Member Author

@mjpost Could you add a branch protection rule for python-dev to prevent it from being deleted? I get a little bit nervous every time I merge something...

@mjpost
Copy link
Member

mjpost commented Jan 3, 2025

I looked but didn't see an option to prevent deletion. But you could always just push it again from local, and even the Github web page allows restoration. Does that address your concern?

@mbollmann
Copy link
Member Author

I looked but didn't see an option to prevent deletion. But you could always just push it again from local, and even the Github web page allows restoration. Does that address your concern?

Settings > Branches > Add branch ruleset, then include the target branch (by pattern "python-dev") and set "Restrict deletions"

@mjpost
Copy link
Member

mjpost commented Jan 3, 2025

Oh, it's a ruleset, not a rule. Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch pypi repo to acl-anthology
2 participants