-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge v0.5.1 release, changes package name to acl-anthology #4305
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4305 +/- ##
=======================================
Coverage 92.55% 92.56%
=======================================
Files 32 32
Lines 2298 2301 +3
=======================================
+ Hits 2127 2130 +3
Misses 171 171
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Via grep -r
, you missed one instance in bin/anthology/__init__.py
.
@mjpost Could you add a branch protection rule for |
I looked but didn't see an option to prevent deletion. But you could always just push it again from local, and even the Github web page allows restoration. Does that address your concern? |
Settings > Branches > Add branch ruleset, then include the target branch (by pattern "python-dev") and set "Restrict deletions" |
Oh, it's a ruleset, not a rule. Done. |
This closes #4300
Also fixes the ReadTheDocs documentation, which hasn't been built anymore after changing repos.