Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix co-author and venue sorting, fixes #4383 #4390

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mbollmann
Copy link
Member

Sorting logic was wrong, this will fix that and close #4383.

@mbollmann mbollmann marked this pull request as draft January 10, 2025 17:21
@mbollmann
Copy link
Member Author

mbollmann commented Jan 10, 2025

Will have another look later if sorting within the same frequency count is also easy to do

EDIT: It was.

Copy link

Build successful. Some useful links:

This preview will be removed when the branch is merged.

@mbollmann mbollmann marked this pull request as ready for review January 10, 2025 21:36
@mbollmann
Copy link
Member Author

@mjpost This sounds a bit worrysome, from the preview build logs:

rsync: write failed on "/var/www/preview.aclanthology.org/fix-frequency-sorting/people/s/sima-sharifirad/index.html": No space left on device (28)

@mbollmann mbollmann requested a review from mjpost January 10, 2025 22:02
@mjpost
Copy link
Member

mjpost commented Jan 10, 2025

The main thing is to clean up branches on the server after they're merged or abandoned; this will then trigger the previews to be removed. I'm cleaning up a few manually and will also request more space.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Author page: sort co-authors and venues by frequency
2 participants