Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented function NOW() #1377

Merged
merged 34 commits into from
Jun 19, 2024
Merged

Implemented function NOW() #1377

merged 34 commits into from
Jun 19, 2024

Conversation

realHannes
Copy link
Collaborator

@realHannes realHannes commented Jun 15, 2024 •
edited by joka921
Loading

NOW() returns ad xsd:DateTime. If it is called multiple times within the same query, then every call to NOW() will return the same result.

realHannes and others added 30 commits April 25, 2024 19:07
@realHannes
Added conversion str to int
99da434
@realHannes
templated function for toNumeric, add declaration to NaryExpression.h
424d023
@realHannes
str to num for SparqlExpression implemented + added test
0117e82
@realHannes
Merge branch 'ad-freiburg:master' into master
35fd0b1
@realHannes @joka921
Update src/engine/sparqlExpressions/StringExpressions.cpp
94356c2 
Co-authored-by: Johannes Kalmbach <[email protected]>
@realHannes @joka921
Update src/engine/sparqlExpressions/StringExpressions.cpp
decc8ba 
Co-authored-by: Johannes Kalmbach <[email protected]>
@realHannes @joka921
Update src/engine/sparqlExpressions/StringExpressions.cpp
850152c 
Co-authored-by: Johannes Kalmbach <[email protected]>
@realHannes @joka921
Update src/engine/sparqlExpressions/StringExpressions.cpp
d650d67 
Co-authored-by: Johannes Kalmbach <[email protected]>
@realHannes
using now absl::from_chars() and stripping whitespaces for string to …
46cc697 
…number conv.
@realHannes
added new functions to processIriFuntionCall() (for string to number)
7fc5c28
@realHannes
renaming to: toIntExpression and toDoubleExpression for later more ge…
efb0e24 
…neral implementation
@realHannes
made format (clang-format-16)
a88537c
@realHannes @joka921
Update src/parser/sparqlParser/SparqlQleverVisitor.cpp
ca1e2e0 
Co-authored-by: Johannes Kalmbach <[email protected]>
@realHannes @joka921
Update src/parser/sparqlParser/SparqlQleverVisitor.cpp
4adc831 
Co-authored-by: Johannes Kalmbach <[email protected]>
@realHannes
renaming in NaryExpression.h for accordance with other function, addi…
d0f0d63 
…ng correct prefix in Constants.h
@realHannes
added test coverage for function calls makeIntExpression and make Dou…
a118609 
…bleExpression
@realHannes
toNumeric has now correct behavior and uses absl::from_chars() and st…
062052e 
…d::from_chars()
@realHannes
made clang-format for NaryExpressionImpl.h
6d0f42a
@realHannes
Merge branch 'ad-freiburg:master' into master
f90b8e2
@realHannes
Merge branch 'ad-freiburg:master' into master
fb88493
@realHannes
Merge remote-tracking branch 'upstream/master'
b2eb514
@realHannes
Merge branch 'ad-freiburg:master' into master
b165ac1
@realHannes
Merge branch 'master' of https://github.com/realHannes/qlever
7a3dfb2
@realHannes
Merge branch 'ad-freiburg:master' into master
fc0ad3a
@realHannes
Merge branch 'ad-freiburg:master' into master
f3e6086
@realHannes
Merge branch 'ad-freiburg:master' into master
fd4c351
@realHannes
Merge branch 'ad-freiburg:master' into master
220c9bf
@realHannes
Merge branch 'ad-freiburg:master' into master
a81cb8a
@realHannes
Merge branch 'ad-freiburg:master' into master
acc0109
@realHannes
first implementation NOW() expression
c0760da
@realHannes realHannes requested a review from joka921 June 15, 2024 10:22
@codecov Codecov
Copy link

codecov bot commented Jun 15, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.90%. Comparing base (f9e730c) to head (86bb70b).

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1377      +/-   ##
==========================================
+ Coverage   88.89%   88.90%   +0.01%     
==========================================
  Files         327      328       +1     
  Lines       28974    28989      +15     
  Branches     3210     3211       +1     
==========================================
+ Hits        25756    25773      +17     
+ Misses       2066     2065       -1     
+ Partials     1152     1151       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

joka921
joka921 requested changes Jun 17, 2024
View reviewed changes
Copy link
Member

@joka921 joka921 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you,
This can be improved a little bit,
but the general framework looks very nice.

src/parser/sparqlParser/SparqlQleverVisitor.h Outdated Show resolved Hide resolved
src/parser/sparqlParser/SparqlQleverVisitor.h Outdated Show resolved Hide resolved
src/parser/SparqlParserHelpers.cpp Outdated Show resolved Hide resolved
src/engine/sparqlExpressions/NowDatetimeExpression.h Outdated Show resolved Hide resolved
src/engine/sparqlExpressions/NowDatetimeExpression.h Outdated Show resolved Hide resolved
src/engine/sparqlExpressions/NowDatetimeExpression.h Outdated Show resolved Hide resolved
src/engine/sparqlExpressions/NowDatetimeExpression.h Outdated Show resolved Hide resolved
test/NowDatetimeExpressionTest.cpp Show resolved Hide resolved
joka921
joka921 requested changes Jun 19, 2024
View reviewed changes
Copy link
Member

@joka921 joka921 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The very last very tiny changes, we are converging!

src/engine/sparqlExpressions/NowDatetimeExpression.h Outdated Show resolved Hide resolved
src/parser/sparqlParser/SparqlQleverVisitor.h Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

joka921
joka921 approved these changes Jun 19, 2024
View reviewed changes
Copy link
Member

@joka921 joka921 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super! Thank you

@joka921 joka921 changed the title implemented sparql-expression NOW() Implemented function NOW() Jun 19, 2024
@joka921 joka921 merged commit 1be8381 into ad-freiburg:master Jun 19, 2024
20 checks passed
joka921 added a commit that referenced this pull request Jun 19, 2024
@joka921
Revert "Implemented function NOW() (#1377)"
cb9e0dd 
This reverts commit 1be8381.
@Rdataflow Rdataflow mentioned this pull request Aug 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joka921 joka921 joka921 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@realHannes @joka921