Also account for the filters when counting the subgraphs.

[joka921]

No description provided.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.87%. Comparing base (acb6633) to head (982cff7).

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1705   +/-   ##
=======================================
  Coverage   89.86%   89.87%           
=======================================
  Files         389      389           
  Lines       37308    37329   +21     
  Branches     4204     4209    +5     
=======================================
+ Hits        33527    33549   +22     
+ Misses       2485     2484    -1     
  Partials     1296     1296           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[hannahbast]

Looks great + nice trick with the filters. A further optimization would be to not have the dummy VALUES "plans" (one for each FILTER) have edges between them.

[hannahbast]

After discussion with Johannes: only add one dummy VALUES clause for each distinct set of variables in a FILTEr. Then we can still overestimate, but the cases where that happens will be rare, and the only bad outcome then is that we compute a greedy query plan in a case, where non-greedy would have worked as well.

[sparql-conformance]

Conformance check passed ✅

No test result changes.

Details: https://qlever.cs.uni-freiburg.de/sparql-conformance-ui?cur=982cff756dc2d031e44813db62ea73aeb6ac33a7&prev=acb6633debc7341985341aff147b5038cc8d951b

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud