Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: deletion of forwardRef (react 19) #2548

Open
wants to merge 29 commits into
base: main
Choose a base branch
from

Conversation

Powerplex
Copy link
Contributor

@Powerplex Powerplex commented Jan 9, 2025

TASK: SPA-473

Description, Motivation and Context

BREAKING CHANGE: forwardRef has been removed from all packages

forwardRef has been deprecated and will be removed (breaking) in future React versions.

Types of changes

  • 🧠 Refactor

Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 98.13320% with 37 lines in your changes missing coverage. Please review.

Project coverage is 96.50%. Comparing base (f8c8bdc) to head (918544c).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
packages/components/dialog/src/DialogContent.tsx 64.28% 5 Missing ⚠️
packages/components/drawer/src/DrawerContent.tsx 44.44% 5 Missing ⚠️
...s/components/accordion/src/AccordionItemHeader.tsx 20.00% 4 Missing ⚠️
...ckages/components/combobox/src/ComboboxTrigger.tsx 91.42% 3 Missing ⚠️
packages/components/input/src/InputGroup.tsx 93.61% 3 Missing ⚠️
packages/components/accordion/src/Accordion.tsx 87.50% 2 Missing ⚠️
...components/alert-dialog/src/AlertDialogContent.tsx 84.61% 2 Missing ⚠️
packages/components/combobox/src/ComboboxInput.tsx 93.33% 2 Missing ⚠️
...omponents/form-field/src/FormFieldStateMessage.tsx 84.61% 2 Missing ⚠️
packages/components/input/src/Input.tsx 91.30% 2 Missing ⚠️
... and 7 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2548      +/-   ##
==========================================
+ Coverage   96.29%   96.50%   +0.20%     
==========================================
  Files         520      520              
  Lines        4432     4605     +173     
  Branches     1433     1621     +188     
==========================================
+ Hits         4268     4444     +176     
+ Misses        162      159       -3     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

some displayName on updated components were breaking

BREAKING CHANGE: forwardRef has been removed from all packages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant