-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ACNA-3397 - web action does not have web in the url, resulting in an invalid link #824
base: master
Are you sure you want to change the base?
Conversation
…n an invalid link
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #824 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 57 58 +1
Lines 3343 3351 +8
Branches 649 648 -1
=========================================
+ Hits 3343 3351 +8 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Couple doc nits
Pre-requisites need to be fulfilled before this is merged. https://jira.corp.adobe.com/browse/ACNA-3418 |
the checks are failing because the dependent PRs have been merged (and the branches deleted), and this is awaiting the module release and updating of package.json |
temporarily updated the PR deps to point to the master branch so checks will pass. |
fixes #823
Pre-requisite
Blocked by
: needs fix: ACNA-3397 - web action does not have web in the url, resulting in an invalid link aio-lib-runtime#197 merged and releasednpm i @adobe/aio-lib-runtime@latest
Blocked by
: fix: ACNA-3397 - excludeweb-export
andraw-http
properties in action, allowweb
property to be boolean aio-cli-lib-app-config#38 merged and releasednpm i @adobe/aio-cli-lib-app-config@latest
How Has This Been Tested?
web
in the url, resulting in an invalid link #823 with a locally linked app plugin and the above runtime lib PR codeTypes of changes
Checklist: