mauve compilation errors (when trying to run on Openjdk11-OpenJ9 SDK)

[smlambert]

Not sure if I am missing a prereq (doesn't appear that any setup step fails), but failing to compile when attempting to run some Java11 tests:

23:03:20 [javac] /tmp/mauve/mauve/gnu/testlet/org/omg/CORBA_2_3/ORB/Valtype/cmInfo.java:15: error: package org.omg.CORBA does not exist
23:03:20 [javac] import org.omg.CORBA.DataInputStream;
23:03:20 [javac] ^
23:03:20 [javac] /tmp/mauve/mauve/gnu/testlet/org/omg/CORBA_2_3/ORB/Valtype/cmInfo.java:16: error: package org.omg.CORBA does not exist
23:03:20 [javac] import org.omg.CORBA.DataOutputStream;
23:03:20 [javac] ^

...

23:03:21 [javac] symbol: class BAD_INV_ORDER
23:03:21 [javac] location: class testAny
23:03:21 [javac] /tmp/mauve/mauve/gnu/testlet/org/omg/CORBA/Any/testAny.java:111: error: cannot find symbol
23:03:21 [javac] throws BAD_OPERATION
23:03:21 [javac] ^

23:03:33 [javac] 100 errors
23:03:33 [javac] 46 warnings

[pshipton]

CORBA is one of the packages removed from Java 11.
eclipse-openj9/openj9#992

[smlambert]

Thanks @pshipton that explains it!

@Mesbah-Alam @lumpfish - Can someone look into this and to any other changes required in systemtest for Java11 support? There are already some Java11 builds ready for testing against
...

[Mesbah-Alam]

Mauve is compiled and used as the workload in the load tests. We need to add an "EE implementation from elsewhere, such as Eclipse Jakarta" (likely https://github.com/javaee/glassfish-corba), for Mauve to compile on Java 11. I will try it out locally and update this PR.

[lumpfish]

I would advocate removing the tests for the removed components. There are already lots of tests which are excluded for one reason or another - the tests' requirement for prereqs being one of them - see https://github.com/AdoptOpenJDK/openjdk-systemtest/blob/master/openjdk.test.mauve/build.xml for how they are excluded at build (configure) time. The tests would also need removing from the load test inventory files in https://github.com/AdoptOpenJDK/openjdk-systemtest/tree/master/openjdk.test.load/config/inventories/mauve

[lumpfish]

@Mesbah-Alam - do you know which are the tests we need to remove or do we need to do some local testing to get the list?

[Mesbah-Alam]

@lumpfish - I have removed the CORBA folders and subsequently been removing referenced Java files (and Java files which fail to compile due to the removal of them) incrementally. Once I reach the point where the build compiles, I'l run the mauve tests locally to see if they still run with these removals in place. I didn't see any direct references of any CORBA classes in any of the inventory files-- but there could be references of tests that have been removed, in which case they'd have to be removed from the inventory xml too.

[Mesbah-Alam]

Update: I've gotten past the mauve compilation issue with Java 11 (finally), but there are some other compilation failures that I am dealing with now, e.g., in modularity test fails to compile with Java 11 as java.transaction module has been removed: https://ci.adoptopenjdk.net/view/work%20in%20progress/job/Grinder/104/console

[Mesbah-Alam]

Peter Shipton confirmed, java.transaction module, on which implementation of several modularity tests depend, have been completely removed in Java 11 as part of eclipse-openj9/openj9#992

Modules removed in java 11:

java.xml.ws (JAX-WS, plus the related technologies SAAJ and Web Services Metadata)
   java.xml.bind (JAXB)
   java.activation (JAF)
   java.xml.ws.annotation (Common Annotations)
   java.corba (CORBA)
   java.transaction (JTA)

   java.se.ee (Aggregator module for the six modules above)
   jdk.xml.ws (Tools for JAX-WS)
   jdk.xml.bind (Tools for JAXB

Following tests need to be rewritten, as they depend on java.transaction:

1) /openjdk.test.modularity/src/tests/com.test/net/adoptopenjdk/test/modularity/junit/TestStressLayers.java
2) /openjdk.test.modularity/src/com.stf/net/adoptopenjdk/test/modularity/PatchModuleImageTest.java
3) /openjdk.test.modularity/src/com.stf/net/adoptopenjdk/test/modularity/PatchModuleTest.java
4) /openjdk.test.modularity/src/com.stf/net/adoptopenjdk/test/modularity/UpgradeModPathTest.java

This work will be tracked by : #150

In the interim, we should exclude modularity tests from compiling/running on Java 11.

[Mesbah-Alam]

Systemtests compile fine with test.modularity excluded: https://ci.adoptopenjdk.net/view/work%20in%20progress/job/Grinder/106/console

Created PR #151 - that contains deletion of the corba related mauve classes and exclusion for modularity for Java 11. @lumpfish - could you please review?

[Mesbah-Alam]

Note: this only unblocks the Java 11 build to run JCK tests which are of higher priority. The personal build I ran only compiled systemtests but didn't run any, as I need to update the playlist and add <subset>SE110</subset> to the tests-- which will be handled in adoptium/aqa-tests#492