-
-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update systemtest to build on Java 11 #151
Update systemtest to build on Java 11 #151
Conversation
Signed-off-by: Mesbah <[email protected]>
What happens with Java 12 :-) |
"What happens with Java 12 :-)". |
Thanks for the explanation! I should have been clearer in my comment. I was referring to using a property isJava11 which possibly needs to be ifJavaGreaterThan10 or something like that and also pick up on newer versions going forwards every 6 months - might need a regex?. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Mesbah-Alam, looks good
Resolves #148
Signed-off-by: Mesbah [email protected]