Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update systemtest to build on Java 11 #151

Merged

Conversation

Mesbah-Alam
Copy link
Contributor

Resolves #148
Signed-off-by: Mesbah [email protected]

@karianna
Copy link
Contributor

What happens with Java 12 :-)

@lumpfish
Copy link
Contributor

lumpfish commented Jul 27, 2018

"What happens with Java 12 :-)".
If (when?) using -classpath becomes invalid the tests would no longer be able to run unless work was done in the mauve project to modularise the tests. The project doesn't appear to have been active since Java 7. Other than that tests become invalid when some backward compatibility is removed (e.g. a number of tests were excluded at Java 9 because '_' was no longer supported as an identifier).
The test suite has generally proved useful over the years for finding regressions and as a general workload for finding VM / JIT issues.

@karianna
Copy link
Contributor

Thanks for the explanation! I should have been clearer in my comment. I was referring to using a property isJava11 which possibly needs to be ifJavaGreaterThan10 or something like that and also pick up on newer versions going forwards every 6 months - might need a regex?.

@Mesbah-Alam
Copy link
Contributor Author

isJava11 is added to temporarily exclude test.modularity project to be built on Java 11. This is added to unblock Java 11 test builds (jck etc) before we come up with the re-implemented modularity test cases. Once PR for #150 is delivered, the isJava11 check will be removed. @karianna

Copy link
Contributor

@karianna karianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karianna karianna merged commit 1669907 into adoptium:master Jul 27, 2018
Copy link
Contributor

@lumpfish lumpfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Mesbah-Alam, looks good

@Mesbah-Alam Mesbah-Alam deleted the systemtest-issues-148-remove-corba branch July 31, 2018 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants