Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vagrant: Improve Test Coverage & Align Tests In VPC process. #3832

Merged
merged 5 commits into from
Dec 3, 2024

Conversation

steelhead31
Copy link
Contributor

@steelhead31 steelhead31 commented Dec 2, 2024

Fixes #3207 & #3288

Update the vagrant playbook check tests of the built JDK, this will now run the standard smoke tests after each build, plus 2 sets of tests ( jdk_math and hotspot_sanity ). These tests are now identical across linux & windows. Also identified a bug whilst testing with Fedora 40, where there is insufficient disk space on the vagrant box to clone the test materials.

Checklist

VPC Run : https://ci.adoptium.net/job/VagrantPlaybookCheck/2025/

Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about this. Adding the smoke tests in is definitely good, but the system tests and MBCS ones were specifically chosen because they validate other bits of the playbook setup (The STF build processes, and the perl installation). It looks like this is removing that validation.

@steelhead31
Copy link
Contributor Author

steelhead31 commented Dec 2, 2024

I'm not sure about this. Adding the smoke tests in is definitely good, but the system tests and MBCS ones were specifically chosen because they validate other bits of the playbook setup (The STF build processes, and the perl installation). It looks like this is removing that validation.

I'll look to identify some equivalents and add those in too, hopefully its a bit simpler to add more tests now I've rationalised the setup a little.

New VPC run in progress : https://ci.adoptium.net/job/VagrantPlaybookCheck/2027/

@sxa
Copy link
Member

sxa commented Dec 2, 2024

I'm not sure about this. Adding the smoke tests in is definitely good, but the system tests and MBCS ones were specifically chosen because they validate other bits of the playbook setup (The STF build processes, and the perl installation). It looks like this is removing that validation.

I'll look to identify some equivalents and add those in too, hopefully its a bit simpler to add more tests now I've rationalised the setup a little.

👍🏻 The important thing here is that we're looking to test the playbooks, not the JDK specifically, so we need a fairly quick to run set that covers anything that might get missed, and thing like the perl modules/language packs can vary between OS distributions so can easily be missed.

@karianna
Copy link
Contributor

karianna commented Dec 3, 2024

I'm not sure about this. Adding the smoke tests in is definitely good, but the system tests and MBCS ones were specifically chosen because they validate other bits of the playbook setup (The STF build processes, and the perl installation). It looks like this is removing that validation.

I'll look to identify some equivalents and add those in too, hopefully its a bit simpler to add more tests now I've rationalised the setup a little.

New VPC run in progress : https://ci.adoptium.net/job/VagrantPlaybookCheck/2027/

Had some failures although not 100% sure related to your changes!

@steelhead31
Copy link
Contributor Author

I'm not sure about this. Adding the smoke tests in is definitely good, but the system tests and MBCS ones were specifically chosen because they validate other bits of the playbook setup (The STF build processes, and the perl installation). It looks like this is removing that validation.

I'll look to identify some equivalents and add those in too, hopefully its a bit simpler to add more tests now I've rationalised the setup a little.
New VPC run in progress : https://ci.adoptium.net/job/VagrantPlaybookCheck/2027/

Had some failures although not 100% sure related to your changes!

I dont think they are, Im rerunning the 2 problem platforms centos7 and debian 10 ( I have a feeling JDK21 doesn't build on debian 10 )... but the first run was successful across Ubuntu 22,24, Fedora 40, Solaris, & Windows, and all builds and tests ran successfully.

@steelhead31 steelhead31 merged commit 7588410 into adoptium:master Dec 3, 2024
7 checks passed
@steelhead31 steelhead31 deleted the update_vpc_tests branch December 3, 2024 12:10
mahdipub pushed a commit to mahdipub/infrastructure that referenced this pull request Dec 5, 2024
…m#3832)

* VPC: Improve VPC JDK Test Process

* VPC: Improve windows tests

* Vagrant: Increase Fedora 40 Disksize

* Vagrant: Add Additional Tests To VPC Testing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MBCS test case in vagrantPlaybookCheck not working in JDK21
4 participants