-
-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vagrant: Improve Test Coverage & Align Tests In VPC process. #3832
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about this. Adding the smoke tests in is definitely good, but the system tests and MBCS ones were specifically chosen because they validate other bits of the playbook setup (The STF build processes, and the perl installation). It looks like this is removing that validation.
I'll look to identify some equivalents and add those in too, hopefully its a bit simpler to add more tests now I've rationalised the setup a little. New VPC run in progress : https://ci.adoptium.net/job/VagrantPlaybookCheck/2027/ |
👍🏻 The important thing here is that we're looking to test the playbooks, not the JDK specifically, so we need a fairly quick to run set that covers anything that might get missed, and thing like the perl modules/language packs can vary between OS distributions so can easily be missed. |
Had some failures although not 100% sure related to your changes! |
I dont think they are, Im rerunning the 2 problem platforms centos7 and debian 10 ( I have a feeling JDK21 doesn't build on debian 10 )... but the first run was successful across Ubuntu 22,24, Fedora 40, Solaris, & Windows, and all builds and tests ran successfully. |
…m#3832) * VPC: Improve VPC JDK Test Process * VPC: Improve windows tests * Vagrant: Increase Fedora 40 Disksize * Vagrant: Add Additional Tests To VPC Testing.
Fixes #3207 & #3288
Update the vagrant playbook check tests of the built JDK, this will now run the standard smoke tests after each build, plus 2 sets of tests ( jdk_math and hotspot_sanity ). These tests are now identical across linux & windows. Also identified a bug whilst testing with Fedora 40, where there is insufficient disk space on the vagrant box to clone the test materials.
Checklist
VPC Run : https://ci.adoptium.net/job/VagrantPlaybookCheck/2025/