Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix some issues #642

Closed
wants to merge 2 commits into from
Closed

fix some issues #642

wants to merge 2 commits into from

Conversation

xyq-c-cpp
Copy link
Collaborator

@xyq-c-cpp xyq-c-cpp commented Dec 4, 2024 •
edited
Loading

  1. support /fapi/v3/positionRisk; close Request upgrade NewGetPositionRiskService V2 => V3 #602
  2. use built-in json; close Use built-in json package instead of json-iterator #638
  3. enable websocket compression; close Enable WS compression #613
  4. close AmountToLotSize works incorrect #615
  5. fix Fix /sapi/v1/sub-account/universalTransfer Signature for this request is not valid. #639 , This is the fundamental approach to fix this issue. Fix issue [Signature error when request parameter content includes @]
    1. Currently, only the binance module has been repaired, and other modules have not been involved yet. Do not modify them for now.

@xyq-c-cpp
Copy link
Collaborator Author

review this @adshao

@adshao
Copy link
Owner

adshao commented Dec 4, 2024

Hi @xyq-c-cpp , I suggest submitting separate PRs for each issue so that we can easily revert a single PR if there are any errors in the code.

@xyq-c-cpp xyq-c-cpp closed this Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@xyq-c-cpp @adshao