-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(major): Refactor entire india banking client side flows #13
Open
Bhavan23
wants to merge
84
commits into
dev
Choose a base branch
from
refactor-dev
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
84 commits
Select commit
Hold shift + click to select a range
9fcc39b
refactor: enable payment request creation for adhoc payment.
Bhavan23 50baba5
refactor: override the payment request's "make_payment_request_function"
Bhavan23 4dd7187
refactor: remove the overrite payment request.
Bhavan23 7100cc4
refactor: Create a custom payment field for both payment orders and r…
Bhavan23 6a982d7
refactor: enable create payment request button in purchase order and …
Bhavan23 96cb562
refactor: modify payment_order_type option with journal entries
Bhavan23 2c416db
refactor: add default bank
Bhavan23 59a753e
refactor: create default mode of transfer
Bhavan23 4cca4f2
refactor: add default payment type
Bhavan23 ab6574f
refactor: Place uninstall hooks in a different file.
Bhavan23 053ec3b
fix: remove payment order copy file
Bhavan23 18b2562
refactor: take out the bank event and add it to the bank overrite class.
Bhavan23 ced0555
fix: remove overrides bank and use docevent hooks
Bhavan23 acc11ad
refactor: payments button label and api path
Bhavan23 7769578
refactor: remove purchase order and purchase invoice js overrides
Bhavan23 d4238a0
fix: create default mode of transfers
Bhavan23 8f6eadf
fix: remove patch file
Bhavan23 f9d53d5
refactor: remove unused function and imports from utils
Bhavan23 a130b7e
refactor: remove unused api file
Bhavan23 f0b8ec8
refactor: format indentation
Bhavan23 8d247b6
refactor: remove unused file from doc_events
Bhavan23 bcea160
refactor: create custom fields
Bhavan23 ca33687
refactor: remove customisation exports
Bhavan23 5c8068f
refactor: remove bank payment request doc
Bhavan23 98f6575
safty commit
Bhavan23 9aa3f2e
refactor: bulk payment code add in bank connector
Bhavan23 c8190a2
refactor: revamped payment status code in bank connector
Bhavan23 f2e03d1
fix: convert the request log to look prettier
Bhavan23 041b86f
fix: handle payment response json validation erro
Bhavan23 1c0b726
refactor: refactor and optimize
Bhavan23 62fe81f
typo: remove debugger-throw on payment order validation
Bhavan23 a12094f
feat: implement workflow enabling/disabling functionality in IndiaBan…
Bhavan23 a82af1a
safety_commit
Bhavan23 a8cd08a
fix: change variable name to python snake case
Bhavan23 7ee6a6c
Merge pull request #12 from aerele/safety-commit-new
Bhavan23 e28e4c3
refactor: add summarise based on field
Bhavan23 83a6919
refactor: modify all is party-wise condition to summarise based on c…
Bhavan23 c360f36
refactor: pretify
Bhavan23 6e8a23c
feat: update dimension while summarising the payment order
Bhavan23 62b6087
refactor: add default bankaccount validation
Bhavan23 818b1b0
refactor: modify SQL query using query builder
Bhavan23 94af04d
fix: use bank account filter to fetch bank entry
Bhavan23 7a4f927
refactor: recreate Bank Payment Request with disabled create options
Bhavan23 0a6f8e3
refactor: prettify the payment request js code
Bhavan23 32f0851
refactor: remove the bank account fixture workflow
Bhavan23 0cf8191
refactor: optimise bank doc_events code
Bhavan23 aab8f6b
fix: remove payment order from accounting dimention hook
Bhavan23 5f51998
fix: update payment status before reinitiate payment.
Bhavan23 9fa4b72
refactor: while create api log return name ref
Bhavan23 71ec851
fix: add summarize based on only draft state
Bhavan23 660c80d
feat: add pending payment cancel button
Bhavan23 d13164d
refactor: add custom field update patch
Bhavan23 dc69f0d
fix: while create payment entry modify filter condition with accounti…
Bhavan23 b20ba2e
feat: set party field name for share holder and customer party type
Bhavan23 901ea7b
fix: reload doc once value update
Bhavan23 316ebd6
refactor: optimise 'validate_summary' method
Bhavan23 41dea60
refactor: optimise update payment status method
Bhavan23 ff3f27c
refactor: optimise payment entry py file
Bhavan23 418623b
refactor: optimise payment request python code
Bhavan23 f706ad0
refactor: add translate to all message
Bhavan23 bf6d5c5
fix: while process payment request summarise field extend with paymen…
Bhavan23 336b5cf
refactor: move "get_bank_balance" function in bank connector
Bhavan23 a7b871b
refactor: remove unused function from payment_order python file
Bhavan23 eb16ac0
refactor: stop bank payment request client actions
Bhavan23 848611f
refactor: stop bank payment request client actions
Bhavan23 c1a3410
typo: use js multiline string syntax instead of useing "`"
Bhavan23 c26fa4b
fix: add payment create_payment_entry function in payment order
Bhavan23 bb6dc91
fix: update Approved status as completed
Bhavan23 d0e1781
fix: remove doc.reload avoid data loss
Bhavan23 80b9214
feat: add payment in the background useing enable_payment_in_the_back…
Bhavan23 d949117
style: format codebase with linter
Bhavan23 60fee11
refactor: enable mode of transfer while installing
Bhavan23 8cb72e6
refactor: add translate to message
Bhavan23 c1113a4
fix: include payload with summary row details for payment reference
Bhavan23 206933e
feat: In the log doc, add a button to display the failure reason.
Bhavan23 0e0bd26
feat: create default payment type for company
Bhavan23 2d84dc0
refactor: remove custom field deletetion without checking filter.
Bhavan23 9454881
chore: rename bank_balance key to get_bank_balance
Bhavan23 7e7e99c
fix: change 'or' condition instead of 'and'
Bhavan23 a5a5f71
fix: update currency filter for payment cycle
Bhavan23 d91e258
refactor: remove unique id and filereference id fields
Bhavan23 3bcd08a
refactor: modify the payment api structure
Bhavan23 b06929b
feat: add settings to reposting entry
Bhavan23 9a47597
feat: handle unreconcil payment
Bhavan23 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,118 @@ | ||
| PAYMENT_SUMMARIES_FIELDS = [ | ||
| "party_type", | ||
| "party", | ||
| "bank_account", | ||
| "account", | ||
| "cost_center", | ||
| "project", | ||
| "tax_withholding_category", | ||
| "reference_doctype", | ||
| "reference_name", | ||
| "payment_entry", | ||
| "journal_entry_account", | ||
| ] | ||
|
|
||
| DEFAULT_MODE_OF_TRANSFERS = [ | ||
| { | ||
| "mode": "A2A/FT/Internal", | ||
| "minimum_limit": 1, | ||
| "maximum_limit": 500000000, | ||
| "start_time": "0:00:00", | ||
| "end_time": "23:59:59", | ||
| "disabled": 0, | ||
| "priority": "1", | ||
| }, | ||
| { | ||
| "mode": "IMPS", | ||
| "minimum_limit": 1, | ||
| "maximum_limit": 200000, | ||
| "start_time": "0:00:00", | ||
| "end_time": "23:59:59", | ||
| "disabled": 0, | ||
| "priority": "2", | ||
| }, | ||
| { | ||
| "mode": "RTGS", | ||
| "minimum_limit": 200000, | ||
| "maximum_limit": 500000000, | ||
| "start_time": "0:00:00", | ||
| "end_time": "23:59:59", | ||
| "disabled": 0, | ||
| "priority": "3", | ||
| }, | ||
| { | ||
| "mode": "NEFT", | ||
| "minimum_limit": 1, | ||
| "maximum_limit": 500000000, | ||
| "start_time": "0:00:00", | ||
| "end_time": "23:59:59", | ||
| "disabled": 0, | ||
| "priority": "4", | ||
| }, | ||
| ] | ||
|
|
||
| STD_BANK_LIST = [ | ||
| "Axis Bank", | ||
| "HDFC Bank", | ||
| "ICICI Bank", | ||
| "Kotak Mahindra Bank", | ||
| ] | ||
|
|
||
| DEFAULT_WORKFLOW_STATE = [ | ||
| "Pending", | ||
| "Approved", | ||
| ] | ||
|
|
||
| DEFAULT_WORKFLOW_ACTIONS = ["Approve", "Reject"] | ||
|
|
||
| DEFAULT_WORKFLOW_LIST = [ | ||
| { | ||
| "doctype": "Workflow", | ||
| "document_type": "Bank Account", | ||
| "workflow_name": "Bank Account Approval", | ||
| "workflow_state_field": "workflow_state", | ||
| "is_active": 1, | ||
| "states": [ | ||
| { | ||
| "allow_edit": "All", | ||
| "doc_status": "0", | ||
| "parent": "Bank Account Approval", | ||
| "parentfield": "states", | ||
| "parenttype": "Workflow", | ||
| "state": "Pending", | ||
| "update_value": "Pending", | ||
| }, | ||
| { | ||
| "allow_edit": "Accounts Manager", | ||
| "doc_status": "0", | ||
| "parent": "Bank Account Approval", | ||
| "parentfield": "states", | ||
| "parenttype": "Workflow", | ||
| "state": "Approved", | ||
| "update_value": "Approved", | ||
| }, | ||
| ], | ||
| "transitions": [ | ||
| { | ||
| "state": "Pending", | ||
| "action": "Approve", | ||
| "next_state": "Approved", | ||
| "allowed": "Accounts Manager", | ||
| "allow_self_approval": 1, | ||
| "parent": "Bank Account Approval", | ||
| "parentfield": "transitions", | ||
| "parenttype": "Workflow", | ||
| }, | ||
| { | ||
| "action": "Reject", | ||
| "next_state": "Pending", | ||
| "allowed": "Accounts Manager", | ||
| "allow_self_approval": 1, | ||
| "parent": "Bank Account Approval", | ||
| "parentfield": "transitions", | ||
| "parenttype": "Workflow", | ||
| "state": "Approved", | ||
| }, | ||
| ], | ||
| } | ||
| ] | ||
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is Axis Bank, removed?