feat(web): Migration to PatternFly 6, round 1 #1895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As a first step before migrating to PatternFly v6
As part of the migration to PF v6. It also use PF/Content for replacing a deprecated PF/Chip.
Use Start and End suffix instead of Left and Right.
No longer used in PF v6.
For using right values for PF v6.
No longer needed in PF v6.
No longer available in PF v6.
As part of the PF v6 migration.
For using PF/Masthead as recommended in PF v6.
As recommended by PF v6.
For accepting the description prop sometimes needed for the header.
To properly look for the menu actions at the document body instead of the row where the toggler lives. This change is needed because in PFv6 "The default value of appendTo on Dropdown, Select, and Popper has been updated to `document.body`" Maybe in the future the appendTo prop is added to the actions menu instead.
Which was wrongly using getByText instead of getByRole for working with buttons.
Switch instead checkbox
Most probably it will be drop in the short term.
Renders an emtpy Masthead instead of nothing when there is not header at all. This is needed in order to have the document structure expected by PatternFly CSS to make things works as expected (i.e., allowing the content fill the space reserved for the sidebar).
Intead of the custom core/Center one, which is going to be deleted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
On October 31th, 2024 PatternFly released it's 6th version, which comes with interesting changes. It's look&feel has changed a lot and it has started to make use of tokens, which can be an opportunity for sanitizing the Agama CSS overrides and to start a good foundation for allowing themes in the Agama web interface. Especially, having in mind that there is a SUSE branding refinement too.
Solution
Start migrating to PatternFly 6.
This first round of changes covers several code adaptations as well as some Agama refinements like the deletion of dead code.
Testing
Screenshots
This first round does not take too much care about the final result, which makes useless taking screenshots.