[web] Fix install button #880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After removing the core-js dependency, `issues.any()` does not work anymore. Thus, more plain JavaScript code has to be used to know if there are any kind of issues.
imobachgs
approved these changes
Nov 21, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
At the time of removing the
core-jsdependency, we didn't realize that core/InstallButton.jsx component was making use ofPromise.anyand it stopped working as expected when asking byclient.issues.any().It's weird since the static
Promise.anymethod is actually supported for all major browsers, but it is not working in the similar way as it was being polyfilled (just a rush conclusion from my side, I didn't investigate it deeply but just deliver a quick fix)Solution
To use, at least by now, just plain (and a bit ugly) JavaScript code for determining if there are pending issues when the user hits the installation button.
Testing