Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate course storage with course management #47

Merged

Conversation

ahmedayman4a
Copy link
Collaborator

@ahmedayman4a ahmedayman4a commented Jan 1, 2025

Depend on PR:

#40

@ahmedayman4a ahmedayman4a changed the base branch from main to devel January 1, 2025 03:02
Copy link

github-actions bot commented Jan 1, 2025

Code Coverage Summary

Overall Project 63.57% -1.23% 🍏
Files changed 74.05% 🍏

File Coverage
ForbiddenException.java 100% 🍏
Video.java 100% 🍏
SecurityConfig.java 100% 🍏
FileValidator.java 100% 🍏
CourseStorageService.java 93.95% 🍏
CourseStorageController.java 89.13% -10.87% 🍏
Lesson.java 78.57% 🍏
GlobalExceptionHandler.java 33.33% 🍏
LessonService.java 23.21% -11.61% 🍏
ModuleService.java 3.92% -1.31%


public LessonService(LessonRepository lessonRepository, ModelMapper modelMapper, ModuleRepository moduleRepository) {
public LessonService(LessonRepository lessonRepository, ModelMapper modelMapper,
ModuleRepository moduleRepository, CourseStorageService courseStorageService, VideoRepository videoRepository) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is nice that you noticed to modify it in the update endpoint.

@MoustafaAmer12 MoustafaAmer12 merged commit 1adcfac into devel Jan 1, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants