Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cluey upgrade #252

Merged
merged 15 commits into from
Nov 1, 2023
Merged

Cluey upgrade #252

merged 15 commits into from
Nov 1, 2023

Conversation

J2thatsme
Copy link
Contributor

No description provided.

@J2thatsme J2thatsme requested a review from mariusgiger October 11, 2023 09:39
janickakenza
janickakenza previously approved these changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@janickakenza janickakenza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff! I left some comments which you could address. 👍

types/comtac/Cluey/analog_input_1.schema.json Outdated Show resolved Hide resolved
types/comtac/Cluey/analog_input_1.schema.json Show resolved Hide resolved
types/comtac/Cluey/configuration.schema.json Show resolved Hide resolved
types/comtac/Cluey/digital_inputs.schema.json Show resolved Hide resolved
types/comtac/Cluey/gps.schema.json Outdated Show resolved Hide resolved
types/comtac/Cluey/temperature_input_3.schema.json Show resolved Hide resolved
types/comtac/Cluey/uplink.js Outdated Show resolved Hide resolved
types/comtac/Cluey/uplink.js Outdated Show resolved Hide resolved
janickakenza
janickakenza previously approved these changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@janickakenza janickakenza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvements!

mariusgiger
mariusgiger requested changes Oct 27, 2023
View reviewed changes
Copy link
Member

@mariusgiger mariusgiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work, a few more proposals

types/comtac/Cluey/uplink.js Show resolved Hide resolved
types/comtac/Cluey/uplink.js Outdated Show resolved Hide resolved
types/comtac/Cluey/uplink.js Outdated Show resolved Hide resolved
types/comtac/Cluey/uplink.spec.js Outdated Show resolved Hide resolved
types/comtac/Cluey/uplink.spec.js Outdated Show resolved Hide resolved
types/comtac/Cluey/uplink.js Show resolved Hide resolved
types/comtac/Cluey/uplink.js Outdated Show resolved Hide resolved
types/comtac/Cluey/uplink.js Show resolved Hide resolved
types/comtac/Cluey/uplink.js Show resolved Hide resolved
types/comtac/Cluey/uplink.js Show resolved Hide resolved
@J2thatsme J2thatsme requested a review from mariusgiger October 27, 2023 13:06
mariusgiger
mariusgiger approved these changes Oct 27, 2023
View reviewed changes
Copy link
Member

@mariusgiger mariusgiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, possibly not output duplicate data with the topic event if there was already a sample emitted (only do it in some cases)

@J2thatsme J2thatsme merged commit 21c2170 into master Nov 1, 2023
6 checks passed
@J2thatsme J2thatsme deleted the clueyUpgrade branch November 1, 2023 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariusgiger mariusgiger mariusgiger approved these changes

@janickakenza janickakenza janickakenza left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@J2thatsme @mariusgiger @janickakenza