repl: improve sorting UX (finos#3293)

* repl: improve sorting UX * repl: customize overlay components for main grid * devex: add 'copyright' code snippet for faster copyright header generation * datacube: add base context menu and support sorting from menu * repl: minor update to webpack flag to build static web content with relative path * data-cube: basic setup with query configuration object * data-cube: introduce loader and change detection mechanism * bump dependencies * data-cube: improve dropdown * data-cube: complete layout for general properties editor panel * bump dependencies * datacube: fix ordering of function composition * data-cube: complete column configuration editor
akphi · Jul 2, 2024 · f16d66b · f16d66b
1 parent 146dd8b
commit f16d66b
Show file tree

Hide file tree

Showing 140 changed files with 5,502 additions and 905 deletions.
diff --git a/.changeset/brave-monkeys-remain.md b/.changeset/brave-monkeys-remain.md
@@ -0,0 +1,29 @@
+---
+'@finos/legend-extension-dsl-data-space-studio': patch
+'@finos/legend-extension-store-service-store': patch
+'@finos/legend-vscode-extension-dependencies': patch
+'@finos/legend-application-repl-deployment': patch
+'@finos/legend-extension-store-relational': patch
+'@finos/legend-server-showcase-deployment': patch
+'@finos/legend-extension-dsl-persistence': patch
+'@finos/legend-extension-store-flat-data': patch
+'@finos/legend-extension-dsl-data-space': patch
+'@finos/legend-extension-dsl-diagram': patch
+'@finos/legend-extension-dsl-service': patch
+'@finos/legend-application-pure-ide': patch
+'@finos/legend-extension-assortment': patch
+'@finos/legend-application-studio': patch
+'@finos/legend-extension-dsl-text': patch
+'@finos/legend-application-query': patch
+'@finos/legend-application-repl': patch
+'@finos/legend-server-showcase': patch
+'@finos/legend-query-builder': patch
+'@finos/legend-application': patch
+'@finos/legend-server-sdlc': patch
+'@finos/legend-dev-utils': patch
+'@finos/stylelint-config-legend-studio': patch
+'@finos/legend-shared': patch
+'@finos/legend-graph': patch
+'@finos/legend-lego': patch
+'@finos/legend-art': patch
+---
diff --git a/.changeset/cool-mayflies-warn.md b/.changeset/cool-mayflies-warn.md
@@ -0,0 +1,17 @@
+---
+'@finos/legend-extension-store-service-store': patch
+'@finos/legend-application-repl-deployment': patch
+'@finos/legend-extension-dsl-data-space': patch
+'@finos/legend-extension-dsl-diagram': patch
+'@finos/legend-application-pure-ide': patch
+'@finos/legend-application-studio': patch
+'@finos/legend-extension-dsl-text': patch
+'@finos/legend-application-query': patch
+'@finos/legend-application-repl': patch
+'@finos/legend-query-builder': patch
+'@finos/legend-dev-utils': patch
+'@finos/stylelint-config-legend-studio': patch
+'@finos/legend-shared': patch
+'@finos/legend-lego': patch
+'@finos/legend-art': patch
+---
diff --git a/.changeset/grumpy-pens-hear.md b/.changeset/grumpy-pens-hear.md
@@ -0,0 +1,4 @@
+---
+'@finos/legend-application-repl': patch
+'@finos/legend-art': patch
+---
diff --git a/.changeset/poor-ligers-teach.md b/.changeset/poor-ligers-teach.md
@@ -0,0 +1,8 @@
+---
+'@finos/legend-application-repl-deployment': patch
+'@finos/legend-application-repl': patch
+'@finos/legend-query-builder': patch
+'@finos/legend-dev-utils': patch
+'@finos/legend-shared': patch
+'@finos/legend-art': patch
+---
diff --git a/.changeset/short-keys-flash.md b/.changeset/short-keys-flash.md
@@ -0,0 +1,5 @@
+---
+'@finos/legend-application-repl-deployment': patch
+'@finos/legend-application-repl': patch
+'@finos/legend-art': patch
+---
diff --git a/.vscode/copyright.code-snippets b/.vscode/copyright.code-snippets
@@ -0,0 +1,7 @@
+{
+  "Print to console": {
+    "prefix": ["copyright"],
+    "body": ["/**\n * Copyright (c) 2020-present, Goldman Sachs\n *\n * Licensed under the Apache License, Version 2.0 (the \"License\");\n * you may not use this file except in compliance with the License.\n * You may obtain a copy of the License at\n *\n *     http://www.apache.org/licenses/LICENSE-2.0\n *\n * Unless required by applicable law or agreed to in writing, software\n * distributed under the License is distributed on an \"AS IS\" BASIS,\n * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n * See the License for the specific language governing permissions and\n * limitations under the License.\n */\n"],
+    "description": "Add copyright header",
+  },
+}
diff --git a/fixtures/legend-mock-server/package.json b/fixtures/legend-mock-server/package.json
@@ -27,7 +27,7 @@
   },
   "dependencies": {
     "@fastify/cors": "9.0.1",
-    "fastify": "4.28.0"
+    "fastify": "4.28.1"
   },
   "devDependencies": {
     "@finos/legend-dev-utils": "workspace:*",

diff --git a/package.json b/package.json
@@ -43,6 +43,7 @@
     "fix:format": "prettier --write --loglevel=warn \"(scripts|docs)/**/*.{md,json,mjs,cjs,js,ts,tsx,html,scss,css}\" \"packages/*/**/*.{md,json,mjs,cjs,js,ts,tsx,html,scss,css}\" && yarn sort-package-json \"package.json\" \"packages/*/package.json\"",
     "fix:js": "cross-env NODE_ENV=production FORCE_COLOR=1 eslint --cache --cache-location ./build/.eslintcache \"scripts/**/*.{mjs,cjs,js,ts,tsx}\" --report-unused-disable-directives --fix && cross-env FORCE_COLOR=1 yarn workspaces foreach --all --parallel --exclude legend-studio -vv run lint:js --fix",
     "fix:style": "yarn lint:style --fix",
+    "fix:watchman": "node ./scripts/test/fixWatchman.js",
     "git:install-hooks": "husky install",
     "git:pre-commit": "lint-staged --config ./package.json",
     "git:upstream:setup": "git remote add upstream https://github.com/finos/legend-studio.git",
@@ -99,14 +100,14 @@
     "@finos/eslint-plugin-legend-studio": "workspace:*",
     "@finos/legend-dev-utils": "workspace:*",
     "@finos/stylelint-config-legend-studio": "workspace:*",
-    "@types/node": "20.14.8",
+    "@types/node": "20.14.9",
     "chalk": "5.3.0",
     "cross-env": "7.0.3",
     "envinfo": "7.13.0",
     "eslint": "8.57.0",
     "fs-extra": "11.2.0",
     "husky": "9.0.11",
-    "inquirer": "9.2.23",
+    "inquirer": "9.3.2",
     "jest": "29.7.0",
     "lint-staged": "15.2.7",
     "micromatch": "4.0.7",
@@ -118,7 +119,7 @@
     "semver": "7.6.2",
     "sort-package-json": "2.10.0",
     "stylelint": "16.6.1",
-    "typedoc": "0.26.2",
+    "typedoc": "0.26.3",
     "typescript": "5.5.2",
     "yargs": "17.7.2"
   },

diff --git a/packages/legend-application-pure-ide/package.json b/packages/legend-application-pure-ide/package.json
@@ -51,7 +51,7 @@
     "@finos/legend-shared": "workspace:*",
     "@types/react": "18.3.3",
     "@types/react-dom": "18.3.0",
-    "mobx": "6.12.4",
+    "mobx": "6.12.5",
     "mobx-react-lite": "4.0.7",
     "monaco-editor": "0.50.0",
     "react": "18.3.1",

diff --git a/packages/legend-application-pure-ide/src/components/editor-group/DiagramEditor.tsx b/packages/legend-application-pure-ide/src/components/editor-group/DiagramEditor.tsx
@@ -41,7 +41,7 @@ import {
   clsx,
   DistributeHorizontalIcon,
   DistributeVerticalIcon,
-  DropdownMenu,
+  ControlledDropdownMenu,
   GoToFileIcon,
   MenuContent,
   MenuContentDivider,
@@ -276,7 +276,7 @@ const DiagramEditorHeader = observer(
             <DistributeVerticalIcon className="diagram-editor__icon--aligner" />
           </button>
         </div>
-        <DropdownMenu
+        <ControlledDropdownMenu
           className="diagram-editor__header__dropdown"
           title="Zoom..."
           content={
@@ -311,7 +311,7 @@ const DiagramEditorHeader = observer(
           <div className="diagram-editor__header__dropdown__trigger diagram-editor__header__zoomer__dropdown__trigger">
             <CaretDownIcon />
           </div>
-        </DropdownMenu>
+        </ControlledDropdownMenu>
         <div className="diagram-editor__header__actions">
           <button
             className="diagram-editor__header__action"

diff --git a/packages/legend-application-query/package.json b/packages/legend-application-query/package.json
@@ -56,7 +56,7 @@
     "@testing-library/react": "16.0.0",
     "@types/react": "18.3.3",
     "@types/react-dom": "18.3.0",
-    "mobx": "6.12.4",
+    "mobx": "6.12.5",
     "mobx-react-lite": "4.0.7",
     "react": "18.3.1",
     "react-dom": "18.3.1",

diff --git a/packages/legend-application-query/src/components/Core_LegendQueryApplicationPlugin.tsx b/packages/legend-application-query/src/components/Core_LegendQueryApplicationPlugin.tsx
@@ -26,7 +26,7 @@ import {
   Button,
   CaretDownIcon,
   DroidIcon,
-  DropdownMenu,
+  ControlledDropdownMenu,
   InfoCircleIcon,
   ManageSearchIcon,
   MenuContent,
@@ -640,7 +640,7 @@ export class Core_LegendQueryApplicationPlugin extends LegendQueryApplicationPlu
                     Save
                   </div>
                 </Button>
-                <DropdownMenu
+                <ControlledDropdownMenu
                   className="query-editor__header__action-combo__dropdown-btn"
                   disabled={editorStore.isViewProjectActionDisabled}
                   title="query__editor__save-dropdown"
@@ -666,7 +666,7 @@ export class Core_LegendQueryApplicationPlugin extends LegendQueryApplicationPlu
                   }
                 >
                   <CaretDownIcon />
-                </DropdownMenu>
+                </ControlledDropdownMenu>
               </div>
             );
           }

diff --git a/packages/legend-application-query/src/components/QueryEditor.tsx b/packages/legend-application-query/src/components/QueryEditor.tsx
@@ -18,7 +18,7 @@ import {
   Dialog,
   PanelLoadingIndicator,
   BlankPanelContent,
-  DropdownMenu,
+  ControlledDropdownMenu,
   MenuContent,
   MenuContentItem,
   MenuIcon,
@@ -622,7 +622,7 @@ export const QueryEditor = observer(() => {
       <div className="query-editor__logo-header">
         <div className="query-editor__logo-header__combo">
           <div className="query-editor__logo-header__combo__menu">
-            <DropdownMenu
+            <ControlledDropdownMenu
               className="query-editor__logo-header__combo__menu-item"
               menuProps={{
                 anchorOrigin: { vertical: 'top', horizontal: 'right' },
@@ -666,7 +666,7 @@ export const QueryEditor = observer(() => {
               }
             >
               <MenuIcon />
-            </DropdownMenu>
+            </ControlledDropdownMenu>
           </div>
           <div className="query-editor__logo-header__combo__name">
             Legend Query

diff --git a/packages/legend-application-query/src/components/QuerySetup.tsx b/packages/legend-application-query/src/components/QuerySetup.tsx
@@ -20,7 +20,7 @@ import {
   QuestionCircleIcon,
   CogIcon,
   MoreHorizontalIcon,
-  DropdownMenu,
+  ControlledDropdownMenu,
   PencilIcon,
   ThinChevronDownIcon,
   CircleIcon,
@@ -214,7 +214,7 @@ const QuerySetupActionGroup = observer(
         )}
         <div className="query-setup__landing-page__action-group__header">
           {(!tag || setupStore.tagToFocus === tag) && (
-            <DropdownMenu
+            <ControlledDropdownMenu
               className="query-setup__landing-page__action-group__config"
               title="Show settings..."
               content={<QuerySetupActionGroupConfigMenu />}
@@ -229,7 +229,7 @@ const QuerySetupActionGroup = observer(
                   <CircleIcon />
                 </div>
               )}
-            </DropdownMenu>
+            </ControlledDropdownMenu>
           )}
         </div>
         <div className="query-setup__landing-page__action-group__body">

diff --git a/packages/legend-application-repl-deployment/repl.config.js b/packages/legend-application-repl-deployment/repl.config.js
@@ -29,11 +29,11 @@ export default {
    */
   baseUrl: '/repl/',
   /**
-   * `isRelativePathSupported` [boolean, optional]
+   * `useRelativePath` [boolean, optional]
    * Boolean flag to check if your website supports resolution of relative
    * paths for resources
    */
-  isRelativePathSupported: true,
+  useRelativePath: true,
   /**
    * `devServerOptions` [object, optional]
    * Options to override `webpack-dev-server` configs.

diff --git a/packages/legend-application-repl-deployment/src/index.html b/packages/legend-application-repl-deployment/src/index.html
@@ -1,7 +1,7 @@
 <!doctype html>
 <html lang="en">
   <head>
-    <title>&#x25A6; Legend DataCube</title>
+    <title>&#x229E; Legend DataCube</title>
     <meta charset="UTF-8" />
     <meta
       name="viewport"

diff --git a/packages/legend-application-repl-deployment/src/index.scss b/packages/legend-application-repl-deployment/src/index.scss
@@ -14,9 +14,9 @@
  * limitations under the License.
  */
 
-@import url('@finos/legend-art/lib/index.css');
+@import url('@finos/legend-art/lib/fonts.css');
 @import url('@finos/legend-application/lib/index.css');
-@import url('@finos/legend-lego/lib/index.css');
+// @import url('@finos/legend-lego/lib/index.css');
 
 @import url('@finos/legend-application-repl/lib/index.css');
 

diff --git a/packages/legend-application-repl-deployment/tailwind.config.js b/packages/legend-application-repl-deployment/tailwind.config.js
@@ -30,6 +30,16 @@ export default {
       '3xl': ['24px', '32px'],
     },
     fontFamily: {
+      sans: [
+        'Roboto',
+        'ui-sans-serif',
+        'system-ui',
+        'sans-serif',
+        'Apple Color Emoji',
+        'Segoe UI Emoji',
+        'Segoe UI Symbol',
+        'Noto Color Emoji',
+      ],
       mono: [
         'ui-monospace',
         'Roboto Mono',

diff --git a/packages/legend-application-repl/package.json b/packages/legend-application-repl/package.json
@@ -49,8 +49,10 @@
     "@ag-grid-community/core": "31.3.2",
     "@ag-grid-community/react": "31.3.2",
     "@ag-grid-community/styles": "31.3.2",
+    "@ag-grid-enterprise/clipboard": "31.3.2",
     "@ag-grid-enterprise/core": "31.3.2",
     "@ag-grid-enterprise/menu": "31.3.2",
+    "@ag-grid-enterprise/range-selection": "31.3.2",
     "@ag-grid-enterprise/row-grouping": "31.3.2",
     "@ag-grid-enterprise/server-side-row-model": "31.3.2",
     "@finos/legend-application": "workspace:*",
@@ -61,7 +63,7 @@
     "@types/react": "18.3.3",
     "@types/react-dom": "18.3.0",
     "antlr4": "4.13.1-patch-1",
-    "mobx": "6.12.4",
+    "mobx": "6.12.5",
     "mobx-react-lite": "4.0.7",
     "monaco-editor": "0.50.0",
     "react": "18.3.1",