Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

14.0 add open in new tab #264

Open
wants to merge 4 commits into
base: 14.0
Choose a base branch
from
Open

Conversation

PierrickBrun
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Apr 17, 2023

Codecov Report

Merging #264 (49ad90a) into 14.0 (2c3ee0c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             14.0     #264   +/-   ##
=======================================
  Coverage   78.79%   78.79%           
=======================================
  Files          98       98           
  Lines        1099     1099           
  Branches      209      209           
=======================================
  Hits          866      866           
  Misses        201      201           
  Partials       32       32           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@rvalyi rvalyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PierrickBrun may be it was just a mistake, but I think it's offensive to put Akretion as a co-author given we only applied minor fixes and lint, probably as a contributor is enough. Let's don't do we others what we don't like others would do with us,,,

@PierrickBrun
Copy link
Member Author

@PierrickBrun may be it was just a mistake, but I think it's offensive to put Akretion as a co-author given we only applied minor fixes and lint, probably as a contributor is enough. Let's don't do we others what we don't like others would do with us,,,

The linter made me do it !

Well I can put a # noqa comment probably

@PierrickBrun PierrickBrun force-pushed the 14.0-add-open_in_new_tab branch from 0374faf to 49ad90a Compare May 24, 2023 12:03
@PierrickBrun PierrickBrun requested a review from rvalyi May 24, 2023 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants