Stop running test-requirements in interactive mode to fix CI
#19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChloePont
approved these changes
Oct 17, 2024
|
No, we don't rely on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
When running
mwaa-local-runner test-requirements, it tries to execute the Docker image in interactive mode. This obviously fails in the CI (since CI is not interactive).That's a regression (it did not happen a year ago, it probably arose when we upgraded this repo to 2.8 by syncing with the original one).
This PR simply removes the interactive tag, which should fix the CI.
Example of a failed CI run because of that issue.