Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc action event #80

Merged
merged 5 commits into from
Oct 1, 2017
Merged

Conversation

oesolberg
Copy link
Contributor

Summary

Added a simple documentation of what functions is involved in making an event action

Description

Added a documentation page and changed the toc for it to appear

Related Issue

Document the template code #2

Motivation and Context

Better documentation for anyone

How Has This Been Tested

No testing

Screenshots (if appropriate)

Types of changes

No code changes

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • [x ] I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have read the CODE OF CONDUCT document.
  • I have added tests to cover my changes if possible
  • All new and existing tests passed.

@alexdresko
Copy link
Owner

Dude, sorry for the delay. I'm catching up, though. Working on pushing a fix for #82 through, then I'll get to this PR. Well done, and super thanks for the contribution!

Copy link
Owner

@alexdresko alexdresko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great additions! I think we'll want to reorganize things a bit once we have more documentation like what you've contributed. It probably deserves its own section, but we'll cross that border when we get to it.

@alexdresko alexdresko merged commit 0a95312 into alexdresko:master Oct 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants