Zimmer62 stuff #94
Zimmer62 stuff #94
Conversation
zimmer62@356e0eb * Non-blocking connect support * Made some protected properties public
| @@ -11,20 +11,20 @@ public static class Connector | |||
| Justification = "The function wouldn't do anything without a plugin.")] | |||
| [SuppressMessage("Microsoft.Design", "CA1031:DoNotCatchGeneralExceptionTypes", | |||
| Justification = "I don't know what kinds of exceptions it _could_ throw.")] | |||
| public static void Connect<TPlugin>(string[] args) where TPlugin : HspiBase, new() | |||
| public static TPlugin Connect<TPlugin>(string[] args, bool pollForShutdown = true) where TPlugin : HspiBase, new() | |||
| { | |||
There was a problem hiding this comment.
So if pollForShutdown is true, the app will exit when the plugin shuts down, and this method will block until it does. And if it isn’t true, this method will return a plug-in instance. Do multiple plugins get loaded at a time? If one of them is polling for shutdown and shuts down then the whole app will exit. Is this intended?
There was a problem hiding this comment.
HS does support multiple plugin instances, but that's ultimately going to be different code. The current HSPI code doesn't support multiple instances. Still have to figure out how all that works.
| @@ -43,7 +43,7 @@ public static void Connect<TPlugin>(string[] args) where TPlugin : HspiBase, new | |||
| // let the plugin do it's thing, wait until it shuts down or the connection to HomeSeer fails. | |||
| try | |||
| { | |||
| while (true) | |||
| while (pollForShutdown) | |||
There was a problem hiding this comment.
Also, based on the behavior you may want to rename it exitOnShutdown and say if (exitOnShutdown) while true {...} }. It’d make it easier to understand.
There was a problem hiding this comment.
Meh, I get what you're saying, but I don't know about exitOnShutdown either. I kinda half-ass threw pollForShutdown on the table just to see if it stuck. Apparently, it didn't. I'll think about it some more before merging, as changing the name later would result in a breaking change.
via zimmer62/HSPI@356e0eb
Rather than introduce a new method as @zimmer62 did, I modified the existing
Connectmethod to optionally return immediately. By default, theConnectfunction works as it always has.