Skip to content

Commit

Permalink
(imp) puppeteer 23.0.0 .. 23.9.0
Browse files Browse the repository at this point in the history
  • Loading branch information
alexey-pelykh committed Dec 18, 2024
1 parent 7d7a7ce commit a93d7ac
Show file tree
Hide file tree
Showing 6 changed files with 58 additions and 60 deletions.
28 changes: 11 additions & 17 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
- lts/jod

env:
PUPPETEER_VERSION: 22.15.0
PUPPETEER_VERSION: 23.9.0

steps:

Expand Down Expand Up @@ -82,22 +82,16 @@ jobs:
- ubuntu-latest
- windows-latest
puppeteer-version:
- '22.0.0'
- '22.1.0'
- '22.2.0'
- '22.3.0'
- '22.4.1'
- '22.5.0'
- '22.6.5'
- '22.7.1'
- '22.8.2'
- '22.9.0'
- '22.10.1'
- '22.11.2'
- '22.12.1'
- '22.13.1'
- '22.14.0'
- '22.15.0'
- '23.0.2'
- '23.1.1'
- '23.2.2'
- '23.3.1'
- '23.4.1'
- '23.5.3'
- '23.6.1'
- '23.7.1'
- '23.8.0'
- '23.9.0'

steps:

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
package:
runs-on: ubuntu-latest
env:
PUPPETEER_VERSION: 22.15.0
PUPPETEER_VERSION: 23.9.0
steps:

- name: Checkout
Expand Down
71 changes: 41 additions & 30 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
"@ffmpeg-installer/ffmpeg": "^1.1.0"
},
"peerDependencies": {
"puppeteer-core": "^22.0.0"
"puppeteer-core": "^23.0.0 <23.10.0"
},
"devDependencies": {
"@types/fluent-ffmpeg": "^2.1.27",
Expand All @@ -56,8 +56,8 @@
"@types/which": "^3.0.4",
"@types/ws": "^8.5.13",
"jest": "^29.7.0",
"puppeteer": "22.15.0",
"puppeteer-core": "22.15.0",
"puppeteer": "23.9.0",
"puppeteer-core": "23.9.0",
"rimraf": "^6.0.1",
"ts-jest": "^29.2.5",
"ts-standard": "^12.0.2",
Expand Down
1 change: 0 additions & 1 deletion src/PuppeteerCaptureViaHeadlessExperimental.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ afterEach(async () => {
test('that capture fails if required args are missing', async () => {
browser = await puppeteer.launch({
executablePath: executablePath(),
headless: 'shell',
args: PUPPETEER_LAUNCH_ARGS
})
const page = await browser.newPage()
Expand Down
10 changes: 2 additions & 8 deletions src/launch.ts
Original file line number Diff line number Diff line change
@@ -1,18 +1,12 @@
import type {
Browser as PuppeteerBrowser,
BrowserConnectOptions as PuppeteerBrowserConnectOptions,
BrowserLaunchArgumentOptions as PuppeteerBrowserLaunchArgumentOptions,
LaunchOptions as PuppeteerLaunchOptions,
Product as PuppeteerProduct
PuppeteerLaunchOptions
} from 'puppeteer-core'
import puppeteer from 'puppeteer-core'
import { PuppeteerCaptureViaHeadlessExperimental } from './PuppeteerCaptureViaHeadlessExperimental'

export async function launch (
options?: PuppeteerLaunchOptions & PuppeteerBrowserLaunchArgumentOptions & PuppeteerBrowserConnectOptions & {
product?: PuppeteerProduct
extraPrefsFirefox?: Record<string, unknown>
}
options?: PuppeteerLaunchOptions
): Promise<PuppeteerBrowser> {
options = {
...(options != null ? options : {}),
Expand Down

0 comments on commit a93d7ac

Please sign in to comment.